DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HOSTCC
Date: Tue, 24 Jun 2014 01:23:03 +0100	[thread overview]
Message-ID: <1403569384-16758-2-git-send-email-bruce.richardson@intel.com> (raw)
In-Reply-To: <1403569384-16758-1-git-send-email-bruce.richardson@intel.com>

when overriding the CC variable on the commandline, the HOSTCC value
was remaining at "gcc", which caused errors on Free BSD10 when using a gcc
as e.g. gcc48, without a binary just called "gcc". This change overrides
HOSTCC when CC is overridden, which means that setting CC=gcc48, will
now also set HOSTCC=gcc48, allowing the "testhost" app to compile on BSD10

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 mk/toolchain/gcc/rte.vars.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk
index 58faa39..39005db 100644
--- a/mk/toolchain/gcc/rte.vars.mk
+++ b/mk/toolchain/gcc/rte.vars.mk
@@ -53,7 +53,11 @@ STRIP     = $(CROSS)strip
 READELF   = $(CROSS)readelf
 GCOV      = $(CROSS)gcov
 
+ifeq ("$(origin CC)", "command line")
+HOSTCC    = $(CC)
+else
 HOSTCC    = gcc
+endif
 HOSTAS    = as
 
 TOOLCHAIN_ASFLAGS =
-- 
1.9.3

  reply	other threads:[~2014-06-24  0:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24  0:23 [dpdk-dev] [PATCH 0/2] minor compile fixes for FreeBSD 10 Bruce Richardson
2014-06-24  0:23 ` Bruce Richardson [this message]
2014-06-24  9:38   ` [dpdk-dev] [PATCH 1/2] mk: overriding CC also overrides HOSTCC Thomas Monjalon
2014-06-24 17:22     ` Richardson, Bruce
2014-06-25 17:26       ` Richardson, Bruce
2014-06-24  0:23 ` [dpdk-dev] [PATCH 2/2] bsdapp: disable ACL library compilation Bruce Richardson
2014-06-27  0:47 ` [dpdk-dev] [PATCH 0/2] minor compile fixes for FreeBSD 10 Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403569384-16758-2-git-send-email-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).