DPDK patches and discussions
 help / color / mirror / Atom feed
From: Helin Zhang <helin.zhang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3 1/7] i40e: fix for getting correct RSS hash result
Date: Tue, 24 Jun 2014 10:02:33 +0800	[thread overview]
Message-ID: <1403575359-10422-2-git-send-email-helin.zhang@intel.com> (raw)
In-Reply-To: <1403575359-10422-1-git-send-email-helin.zhang@intel.com>

It wrongly gets the RSS hash result from the RX descriptor which
has been modified for receiving new packet. The fix is to get the
RSS hash result from the buffer which saves the RX descriptor.

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
Acked-by: Jing Chen <jing.d.chen@intel.com>
Acked-by: Cunming Liang <cunming.liang@intel.com>
---
 lib/librte_pmd_i40e/i40e_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c
index 9fccbee..3a6a2d8 100644
--- a/lib/librte_pmd_i40e/i40e_rxtx.c
+++ b/lib/librte_pmd_i40e/i40e_rxtx.c
@@ -863,7 +863,7 @@ i40e_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
 		rxm->ol_flags = pkt_flags;
 		if (pkt_flags & PKT_RX_RSS_HASH)
 			rxm->pkt.hash.rss =
-				rte_le_to_cpu_32(rxdp->wb.qword0.hi_dword.rss);
+				rte_le_to_cpu_32(rxd.wb.qword0.hi_dword.rss);
 
 		rx_pkts[nb_rx++] = rxm;
 	}
@@ -1016,7 +1016,7 @@ i40e_recv_scattered_pkts(void *rx_queue,
 		first_seg->ol_flags = pkt_flags;
 		if (pkt_flags & PKT_RX_RSS_HASH)
 			rxm->pkt.hash.rss =
-				rte_le_to_cpu_32(rxdp->wb.qword0.hi_dword.rss);
+				rte_le_to_cpu_32(rxd.wb.qword0.hi_dword.rss);
 
 		/* Prefetch data of first segment, if configured to do so. */
 		rte_prefetch0(first_seg->pkt.data);
-- 
1.8.1.4

  reply	other threads:[~2014-06-24  2:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24  2:02 [dpdk-dev] [PATCH v3 0/7] enhancements for i40e Helin Zhang
2014-06-24  2:02 ` Helin Zhang [this message]
2014-06-24  2:02 ` [dpdk-dev] [PATCH v3 2/7] i40evf: remove an interface which is not used Helin Zhang
2014-06-24  2:02 ` [dpdk-dev] [PATCH v3 3/7] i40evf: fix for copying wrong size of link info Helin Zhang
2014-06-24  2:02 ` [dpdk-dev] [PATCH v3 4/7] i40e: fix for updating the hash lookup table of PF RSS Helin Zhang
2014-06-24  2:02 ` [dpdk-dev] [PATCH v3 5/7] i40e: double vlan should be specifically disabled by default Helin Zhang
2014-06-24  2:02 ` [dpdk-dev] [PATCH v3 6/7] i40e: ignore the failure of updating default macvlan filter Helin Zhang
2014-06-24  2:02 ` [dpdk-dev] [PATCH v3 7/7] app/testpmd: rework for displaying different size of RX descriptors Helin Zhang
2014-06-24 11:13 ` [dpdk-dev] [PATCH v3 0/7] enhancements for i40e Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403575359-10422-2-git-send-email-helin.zhang@intel.com \
    --to=helin.zhang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).