DPDK patches and discussions
 help / color / mirror / Atom feed
From: Helin Zhang <helin.zhang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3 4/7] i40e: fix for updating the hash lookup table of PF RSS
Date: Tue, 24 Jun 2014 10:02:36 +0800
Message-ID: <1403575359-10422-5-git-send-email-helin.zhang@intel.com> (raw)
In-Reply-To: <1403575359-10422-1-git-send-email-helin.zhang@intel.com>

The bit shifting were written wrongly in '0x1 < j',
the correct one should be '0x1 << j'.

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
Acked-by: Jing Chen <jing.d.chen@intel.com>
Acked-by: Cunming Liang <cunming.liang@intel.com>
---
 lib/librte_pmd_i40e/i40e_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index 1b4e822..0d7be44 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -1452,7 +1452,7 @@ i40e_dev_rss_reta_update(struct rte_eth_dev *dev,
 			l = I40E_READ_REG(hw, I40E_PFQF_HLUT(i >> 2));
 
 		for (j = 0, lut = 0; j < 4; j++) {
-			if (mask & (0x1 < j))
+			if (mask & (0x1 << j))
 				lut |= reta_conf->reta[i + j] << (8 * j);
 			else
 				lut |= l & (0xFF << (8 * j));
-- 
1.8.1.4

  parent reply	other threads:[~2014-06-24  2:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24  2:02 [dpdk-dev] [PATCH v3 0/7] enhancements for i40e Helin Zhang
2014-06-24  2:02 ` [dpdk-dev] [PATCH v3 1/7] i40e: fix for getting correct RSS hash result Helin Zhang
2014-06-24  2:02 ` [dpdk-dev] [PATCH v3 2/7] i40evf: remove an interface which is not used Helin Zhang
2014-06-24  2:02 ` [dpdk-dev] [PATCH v3 3/7] i40evf: fix for copying wrong size of link info Helin Zhang
2014-06-24  2:02 ` Helin Zhang [this message]
2014-06-24  2:02 ` [dpdk-dev] [PATCH v3 5/7] i40e: double vlan should be specifically disabled by default Helin Zhang
2014-06-24  2:02 ` [dpdk-dev] [PATCH v3 6/7] i40e: ignore the failure of updating default macvlan filter Helin Zhang
2014-06-24  2:02 ` [dpdk-dev] [PATCH v3 7/7] app/testpmd: rework for displaying different size of RX descriptors Helin Zhang
2014-06-24 11:13 ` [dpdk-dev] [PATCH v3 0/7] enhancements for i40e Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403575359-10422-5-git-send-email-helin.zhang@intel.com \
    --to=helin.zhang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git