From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] dpdk_nic_bind: allow status query without igb_uio
Date: Thu, 26 Jun 2014 04:36:38 +0100 [thread overview]
Message-ID: <1403753798-15074-1-git-send-email-bruce.richardson@intel.com> (raw)
From: Bruce richardson <bruce.richardson@intel.com>
Allow the nic bind/unbind script to print out its status messages even
if the igb_uio driver is not loaded. For binding and unbinding NICs, the
behaviour is the same, and the igb_uio driver still needs to be loaded.
Signed-off-by: Bruce richardson <bruce.richardson@intel.com>
---
tools/dpdk_nic_bind.py | 25 ++++++++++++++++++++-----
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py
index 42e845f..da01e01 100755
--- a/tools/dpdk_nic_bind.py
+++ b/tools/dpdk_nic_bind.py
@@ -45,6 +45,12 @@ devices = {}
# list of supported DPDK drivers
dpdk_drivers = [ "igb_uio", "vfio-pci" ]
+# command-line arg flags
+b_flag = None
+status_flag = False
+force_flag = False
+args = []
+
def usage():
'''Print usage information for the program'''
argv0 = basename(sys.argv[0])
@@ -168,7 +174,7 @@ def check_modules():
mod["Found"] = True
# check if we have at least one loaded module
- if True not in [mod["Found"] for mod in mods]:
+ if True not in [mod["Found"] for mod in mods] and b_flag is not None:
print "Error - no supported modules are loaded"
sys.exit(1)
@@ -438,9 +444,10 @@ def show_status():
def parse_args():
'''Parses the command-line arguments given by the user and takes the
appropriate action for each'''
- b_flag = None
- status_flag = False
- force_flag = False
+ global b_flag
+ global status_flag
+ global force_flag
+ global args
if len(sys.argv) <= 1:
usage()
sys.exit(0)
@@ -471,6 +478,13 @@ def parse_args():
else:
b_flag = arg
+def do_arg_actions():
+ '''do the actual action requested by the user'''
+ global b_flag
+ global status_flag
+ global force_flag
+ global args
+
if b_flag is None and not status_flag:
print "Error: No action specified for devices. Please give a -b or -u option"
print "Run '%s --usage' for further information" % sys.argv[0]
@@ -492,9 +506,10 @@ def parse_args():
def main():
'''program main function'''
+ parse_args()
check_modules()
get_nic_details()
- parse_args()
+ do_arg_actions()
if __name__ == "__main__":
main()
--
1.9.3
next reply other threads:[~2014-06-26 3:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 3:36 Bruce Richardson [this message]
2014-06-27 1:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403753798-15074-1-git-send-email-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).