From: Pablo de Lara <pablox.de.lara.guarch@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] test: Remove NULL snprintf tests in cmdline unit test
Date: Mon, 30 Jun 2014 11:52:55 +0100 [thread overview]
Message-ID: <1404125575-25691-1-git-send-email-pablox.de.lara.guarch@intel.com> (raw)
From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cmdline unit test calls several functions that use snprintf,
with NULL pointer as the destination buffer. This patch
eliminates these NULL pointer tests.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
app/test/test_cmdline_etheraddr.c | 7 -------
app/test/test_cmdline_num.c | 7 -------
app/test/test_cmdline_portlist.c | 7 -------
3 files changed, 0 insertions(+), 21 deletions(-)
diff --git a/app/test/test_cmdline_etheraddr.c b/app/test/test_cmdline_etheraddr.c
index 21f5863..45c61ff 100644
--- a/app/test/test_cmdline_etheraddr.c
+++ b/app/test/test_cmdline_etheraddr.c
@@ -161,13 +161,6 @@ test_parse_etheraddr_invalid_param(void)
/* test help function */
memset(&buf, 0, sizeof(buf));
- /* try null buf */
- ret = cmdline_get_help_etheraddr(NULL, NULL, sizeof(buf));
- if (ret != -1) {
- printf("Error: help function accepted null buffer!\n");
- return -1;
- }
-
/* coverage! */
ret = cmdline_get_help_etheraddr(NULL, buf, sizeof(buf));
if (ret < 0) {
diff --git a/app/test/test_cmdline_num.c b/app/test/test_cmdline_num.c
index e865428..799d68c 100644
--- a/app/test/test_cmdline_num.c
+++ b/app/test/test_cmdline_num.c
@@ -395,13 +395,6 @@ test_parse_num_invalid_param(void)
return -1;
}
- /* try null buf */
- ret = cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, NULL, sizeof(buf));
- if (ret != -1) {
- printf("Error: help function accepted null buffer!\n");
- return -1;
- }
-
/* coverage! */
ret = cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, buf, sizeof(buf));
if (ret < 0) {
diff --git a/app/test/test_cmdline_portlist.c b/app/test/test_cmdline_portlist.c
index abba008..9f9633c 100644
--- a/app/test/test_cmdline_portlist.c
+++ b/app/test/test_cmdline_portlist.c
@@ -164,13 +164,6 @@ test_parse_portlist_invalid_param(void)
/* test help function */
- /* try null buf */
- ret = cmdline_get_help_portlist(NULL, NULL, sizeof(buf));
- if (ret != -1) {
- printf("Error: help function accepted null buffer!\n");
- return -1;
- }
-
/* coverage! */
ret = cmdline_get_help_portlist(NULL, buf, sizeof(buf));
if (ret < 0) {
--
1.7.0.7
next reply other threads:[~2014-06-30 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 10:52 Pablo de Lara [this message]
2014-06-30 11:34 ` Olivier MATZ
2014-07-01 22:09 ` Thomas Monjalon
2014-07-01 8:49 ` Cao, Waterman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404125575-25691-1-git-send-email-pablox.de.lara.guarch@intel.com \
--to=pablox.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).