DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pablo de Lara <pablox.de.lara.guarch@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] app/test: Removed vdev test in EAL flags unit test
Date: Mon, 30 Jun 2014 15:42:57 +0100
Message-ID: <1404139377-24580-1-git-send-email-pablox.de.lara.guarch@intel.com> (raw)

From: Pablo de Lara <pablo.de.lara.guarch@intel.com>

In whitelist test, within EAL flags unit test, vdev flag
was being tested, but test fails, as a secondary process
cannot allocate memzones, so it cannot create the device
and application exits. Also, this can be tested in ring
pmd test, which needs vdev and not in whitelist, which
should only test --pci-whitelist.

Patch "app/test: fix build switches to enable cmdline tests"
from Thomas Monjalon is needed for this patch.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
 app/test/test_eal_flags.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 1b80b80..7c6656b 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -58,7 +58,6 @@
 #define no_huge "--no-huge"
 #define no_shconf "--no-shconf"
 #define pci_whitelist "--pci-whitelist"
-#define vdev "--vdev"
 #define memtest "memtest"
 #define memtest1 "memtest1"
 #define memtest2 "memtest2"
@@ -317,9 +316,6 @@ test_whitelist_flag(void)
 	const char *wlval3[] = {prgname, prefix, mp_flag, "-n", "1", "-c", "1",
 			pci_whitelist, "09:0B.3,type=test",
 			pci_whitelist, "08:00.1,type=normal",
-			vdev, "eth_ring,arg=test",
 	for (i = 0; i < sizeof(wlinval) / sizeof(wlinval[0]); i++) {

             reply	other threads:[~2014-06-30 14:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 14:42 Pablo de Lara [this message]
2014-07-01  8:31 ` Olivier MATZ
2014-07-01  8:32   ` [dpdk-dev] [PATCH] app/test: fix vdev test in test_eal_flags Olivier Matz
2014-07-01  8:59   ` [dpdk-dev] [PATCH] app/test: Removed vdev test in EAL flags unit test De Lara Guarch, Pablo
2014-07-01  9:20     ` Olivier MATZ
2014-07-01  9:21       ` [dpdk-dev] [PATCH v2] app/test: fix vdev test in test_eal_flags Olivier Matz
2014-07-01 11:44         ` De Lara Guarch, Pablo
2014-07-01 12:00           ` Olivier MATZ
2014-07-01 12:11             ` De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404139377-24580-1-git-send-email-pablox.de.lara.guarch@intel.com \
    --to=pablox.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git