DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] ring_pmd: Removed extra devices creation when passing vdev parameter
Date: Wed,  9 Jul 2014 15:35:35 +0100	[thread overview]
Message-ID: <1404916536-1364-2-git-send-email-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <1404916536-1364-1-git-send-email-pablo.de.lara.guarch@intel.com>

When passing extra arguments in EAL option --vdev, to create
ring ethdevs, API was creating three ethdevs, even if there
was just one argument, such as CREATE.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 lib/librte_pmd_ring/rte_eth_ring.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/lib/librte_pmd_ring/rte_eth_ring.c b/lib/librte_pmd_ring/rte_eth_ring.c
index 73c649e..4f1b6ed 100644
--- a/lib/librte_pmd_ring/rte_eth_ring.c
+++ b/lib/librte_pmd_ring/rte_eth_ring.c
@@ -493,7 +493,6 @@ rte_pmd_ring_devinit(const char *name, const char *params)
 			eth_dev_ring_create(name, rte_socket_id(), DEV_CREATE);
 			return 0;
 		} else {
-			eth_dev_ring_create(name, rte_socket_id(), DEV_CREATE);
 			ret = rte_kvargs_count(kvlist, ETH_RING_NUMA_NODE_ACTION_ARG);
 			info = rte_zmalloc("struct node_action_list", sizeof(struct node_action_list) +
 					   (sizeof(struct node_action_pair) * ret), 0);
@@ -510,7 +509,7 @@ rte_pmd_ring_devinit(const char *name, const char *params)
 				goto out_free;
 
 			for (info->count = 0; info->count < info->total; info->count++) {
-				eth_dev_ring_pair_create(name, info->list[info->count].node,
+				eth_dev_ring_create(name, info->list[info->count].node,
 						    info->list[info->count].action);
 			}
 		}
-- 
1.7.0.7

  reply	other threads:[~2014-07-09 14:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 14:35 [dpdk-dev] [PATCH 0/2] Fixed/Simplified Ring PMD Pablo de Lara
2014-07-09 14:35 ` Pablo de Lara [this message]
2014-07-09 14:35 ` [dpdk-dev] [PATCH 2/2] app/test: Simplified ring pmd test Pablo de Lara
2014-07-09 15:20 ` [dpdk-dev] [PATCH 0/2] Fixed/Simplified Ring PMD Neil Horman
2014-07-09 20:07   ` [dpdk-dev] PMD for Cisco VIC Ethernet NIC - Request for guidelines for submission Hobywan Kenoby
2014-07-11  7:46     ` Sujith Sankar (ssujith)
2014-07-11 13:16       ` Hobywan Kenoby
2014-07-21  3:39         ` Sujith Sankar (ssujith)
2014-07-22 14:54   ` [dpdk-dev] [PATCH 0/2] Fixed/Simplified Ring PMD Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404916536-1364-2-git-send-email-pablo.de.lara.guarch@intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).