DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 3/6] mk: Ensure correct detection of SSE4.2 on FreeBSD
Date: Thu, 17 Jul 2014 22:47:45 +0100	[thread overview]
Message-ID: <1405633665-7659-1-git-send-email-bruce.richardson@intel.com> (raw)
In-Reply-To: <1404776219-6130-4-git-send-email-bruce.richardson@intel.com>

Add a special case to the native target makefile, where we check if
-march=native shows SSE4.2 support. If it does not, then not everything may
build, so we check if the hardware supports SSE4.2, and use a corei7 target
explicitly to get the SSE4.2 support.

New in V2:
* Re-enable ACL library for FreeBSD using gcc, which requires SSE4.2
* Adjust SSE42 detection command based on feedback from Thomas Monjalon

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 config/defconfig_x86_64-native-bsdapp-gcc |  5 -----
 mk/machine/native/rte.vars.mk             | 12 ++++++++++++
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/config/defconfig_x86_64-native-bsdapp-gcc b/config/defconfig_x86_64-native-bsdapp-gcc
index 2234193..e91738b 100644
--- a/config/defconfig_x86_64-native-bsdapp-gcc
+++ b/config/defconfig_x86_64-native-bsdapp-gcc
@@ -69,8 +69,3 @@ CONFIG_RTE_ARCH_X86_64=y
 #
 CONFIG_RTE_TOOLCHAIN="gcc"
 CONFIG_RTE_TOOLCHAIN_GCC=y
-
-#
-# GCC doesn't detect SSE4.x support correctly on BSD, so disable ACL lib
-#
-CONFIG_RTE_LIBRTE_ACL=n
diff --git a/mk/machine/native/rte.vars.mk b/mk/machine/native/rte.vars.mk
index da9aa71..baabb39 100644
--- a/mk/machine/native/rte.vars.mk
+++ b/mk/machine/native/rte.vars.mk
@@ -56,3 +56,15 @@
 # CPU_ASFLAGS =
 
 MACHINE_CFLAGS = -march=native
+
+# on FreeBSD systems, sometimes the correct cputype is not picked up.
+# To get everything to compile, we need SSE4.2 support, so check if that is
+# reported by compiler. If not, check if the CPU actually supports it, and if
+# so, set the compilation target to be a corei7, minimum target with SSE4.2
+SSE42_SUPPORT=$(shell $(CC) -march=native -dM -E - < /dev/null | grep SSE4_2)
+ifeq ($(SSE42_SUPPORT),)
+  CPU_SSE42_SUPPORT=$(shell grep SSE4\.2 /var/run/dmesg.boot 2>/dev/null)
+  ifneq ($(CPU_SSE42_SUPPORT),)
+    MACHINE_CFLAGS= -march=corei7
+  endif
+endif
-- 
2.0.0

  parent reply	other threads:[~2014-07-17 21:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-07 23:36 [dpdk-dev] [PATCH 0/6] Clang compilation support on FreeBSD and Linux Bruce Richardson
2014-07-07 23:36 ` [dpdk-dev] [PATCH 1/6] pmd_bond: add missing variable initialization Bruce Richardson
2014-07-07 23:36 ` [dpdk-dev] [PATCH 2/6] Makefiles: add clang to compiler if/else block Bruce Richardson
2014-07-07 23:36 ` [dpdk-dev] [PATCH 3/6] mk: Ensure correct detection of SSE4.2 on FreeBSD Bruce Richardson
2014-07-17  9:35   ` Thomas Monjalon
2014-07-17 21:42     ` Bruce Richardson
2014-07-17 10:25   ` Thomas Monjalon
2014-07-17 14:41     ` Richardson, Bruce
2014-07-17 21:47   ` Bruce Richardson [this message]
2014-07-07 23:36 ` [dpdk-dev] [PATCH 4/6] acl: add nmmintrin.h header to allow clang compilation Bruce Richardson
2014-07-07 23:36 ` [dpdk-dev] [PATCH 5/6] mk: add toolchain for clang and linuxapp target Bruce Richardson
2014-07-17 10:23   ` Thomas Monjalon
2014-07-17 17:54     ` Richardson, Bruce
2014-07-07 23:36 ` [dpdk-dev] [PATCH 6/6] config: add compile target for clang on BSD Bruce Richardson
2014-07-11  5:31 ` [dpdk-dev] [PATCH 0/6] Clang compilation support on FreeBSD and Linux Zhan, Zhaochen
2014-07-18 23:58 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405633665-7659-1-git-send-email-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).