From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 30567959 for ; Fri, 18 Jul 2014 06:00:45 +0200 (CEST) Received: by mail-pa0-f53.google.com with SMTP id kq14so4527467pab.26 for ; Thu, 17 Jul 2014 21:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=vnSclFA0dcy5dLGu10rQPWo30iv6HQiWZ4I+2RPc9fA=; b=tYZXIddWaXSysf3DgyCHta+96BSnXy22x73SNiaa9M7hyR2o/vFEP0/d2SeOtiFf9l gCnmXZmLGf8oc2VjHRzXPSA/54VnxtJc+X7hgGHft1V5zicgeXEyyWMeUxYBA0c1MVIF uvfkscxMoojUuHWgTTob+OSo4YLDL9+D+wJGsEwll17a89TCJmDP4za4Bu5NVZD2eDMu GNNi5Wl+BYjTD2SMdno6IvK3qJ6U8pSYtH9hNUGldy7hgClT6OOBVod2wVVTofuoVhPp WI26eZWrfvjzMRg1h/79uPNigzTCKKMG/AQC0AP6ueNnwrwkoAZntf0mtdOY/XfsW8UO khHg== X-Received: by 10.70.41.171 with SMTP id g11mr1869044pdl.16.1405656103052; Thu, 17 Jul 2014 21:01:43 -0700 (PDT) Received: from localhost.localdomain.com ([144.49.130.78]) by mx.google.com with ESMTPSA id yo9sm17756374pac.25.2014.07.17.21.01.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jul 2014 21:01:42 -0700 (PDT) From: Vijayakumar Muthuvel Manickam To: dev@dpdk.org Date: Fri, 18 Jul 2014 03:53:48 -0700 Message-Id: <1405680828-88424-1-git-send-email-mmvijay@gmail.com> X-Mailer: git-send-email 1.7.1 Subject: [dpdk-dev] [PATCH v2] virtio: Fix 32bit pmd for 64bit kernel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jul 2014 04:00:45 -0000 *virtio_net_hdr_mem* member within *virtqueue* structure stores a physical address and is defined as void ptr. When 32bit pmd is used with 64bit kernel this leads to truncation of 64bit physical address and pkt i/o does not work. Changed *virtio_net_hdr_mem* to *phys_addr_t* type and removed the typecasts Signed-off-by: Vijayakumar Muthuvel Manickam --- lib/librte_pmd_virtio/virtio_ethdev.c | 6 +++--- lib/librte_pmd_virtio/virtqueue.h | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virtio/virtio_ethdev.c index d4730f9..764a769 100644 --- a/lib/librte_pmd_virtio/virtio_ethdev.c +++ b/lib/librte_pmd_virtio/virtio_ethdev.c @@ -331,7 +331,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev, PMD_INIT_LOG(DEBUG, "vq->vq_ring_mem: 0x%"PRIx64"\n", (uint64_t)mz->phys_addr); PMD_INIT_LOG(DEBUG, "vq->vq_ring_virt_mem: 0x%"PRIx64"\n", (uint64_t)mz->addr); vq->virtio_net_hdr_mz = NULL; - vq->virtio_net_hdr_mem = (void *)NULL; + vq->virtio_net_hdr_mem = 0; if (queue_type == VTNET_TQ) { /* @@ -347,7 +347,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev, return -ENOMEM; } vq->virtio_net_hdr_mem = - (void *)(uintptr_t)vq->virtio_net_hdr_mz->phys_addr; + vq->virtio_net_hdr_mz->phys_addr; memset(vq->virtio_net_hdr_mz->addr, 0, vq_size * sizeof(struct virtio_net_hdr)); } else if (queue_type == VTNET_CQ) { @@ -361,7 +361,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev, return -ENOMEM; } vq->virtio_net_hdr_mem = - (void *)(uintptr_t)vq->virtio_net_hdr_mz->phys_addr; + vq->virtio_net_hdr_mz->phys_addr; memset(vq->virtio_net_hdr_mz->addr, 0, PAGE_SIZE); } diff --git a/lib/librte_pmd_virtio/virtqueue.h b/lib/librte_pmd_virtio/virtqueue.h index a63723d..e244199 100644 --- a/lib/librte_pmd_virtio/virtqueue.h +++ b/lib/librte_pmd_virtio/virtqueue.h @@ -152,7 +152,7 @@ struct virtqueue { */ uint16_t vq_used_cons_idx; uint16_t vq_avail_idx; - void *virtio_net_hdr_mem; /**< hdr for each xmit packet */ + phys_addr_t virtio_net_hdr_mem; /**< hdr for each xmit packet */ struct vq_desc_extra { void *cookie; @@ -354,7 +354,8 @@ virtqueue_enqueue_xmit(struct virtqueue *txvq, struct rte_mbuf *cookie) dxp->ndescs = needed; start_dp = txvq->vq_ring.desc; - start_dp[idx].addr = (uint64_t)(uintptr_t)txvq->virtio_net_hdr_mem + idx * sizeof(struct virtio_net_hdr); + start_dp[idx].addr = + txvq->virtio_net_hdr_mem + idx * sizeof(struct virtio_net_hdr); start_dp[idx].len = sizeof(struct virtio_net_hdr); start_dp[idx].flags = VRING_DESC_F_NEXT; idx = start_dp[idx].next; -- 1.7.1