DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ouyang Changchun <changchun.ouyang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/3] ether: Update field name and description for queue start
Date: Tue, 22 Jul 2014 15:47:30 +0800	[thread overview]
Message-ID: <1406015252-27804-2-git-send-email-changchun.ouyang@intel.com> (raw)
In-Reply-To: <1406015252-27804-1-git-send-email-changchun.ouyang@intel.com>

Rename the field name from start_rx_per_q to rx_enable_queue in
struct rte_eth_rxconf, and do same thing for TX.
 
This patch also update description for field rx_enable_queue and tx_enable_queue.

Signed-off-by: Ouyang Changchun <changchun.ouyang@intel.com>
---
 lib/librte_ether/rte_ethdev.h | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 50df654..a452810 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -604,7 +604,16 @@ struct rte_eth_rxconf {
 	struct rte_eth_thresh rx_thresh; /**< RX ring threshold registers. */
 	uint16_t rx_free_thresh; /**< Drives the freeing of RX descriptors. */
 	uint8_t rx_drop_en; /**< Drop packets if no descriptors are available. */
-	uint8_t start_rx_per_q; /**< start rx per queue. */
+	/**< If rx_enable_queue is true, rte_eth_dev_rx_queue_start must be
+		invocated after rte_eth_dev_start's invocation to start RX for
+		one queue, and rte_eth_dev_rx_queue_start instead of
+		rte_eth_dev_start is responsible for allocating mbuf from
+		mempool and setup the DMA physical address. It is useful in
+		such scenario: buffer address is not available at the point of
+		rte_eth_dev_start's invocation but available later, e.g. in
+		VHOST zero copy case, the buffer address to be setup DMA
+		address is available only after one VM startup. */
+	uint8_t rx_enable_queue;
 };
 
 #define ETH_TXQ_FLAGS_NOMULTSEGS 0x0001 /**< nb_segs=1 for all mbufs */
@@ -625,7 +634,10 @@ struct rte_eth_txconf {
 	uint16_t tx_rs_thresh; /**< Drives the setting of RS bit on TXDs. */
 	uint16_t tx_free_thresh; /**< Drives the freeing of TX buffers. */
 	uint32_t txq_flags; /**< Set flags for the Tx queue */
-	uint8_t start_tx_per_q; /**< start tx per queue. */
+	/**< If tx_enable_queue is true, rte_eth_dev_tx_queue_start must be
+		invocated after rte_eth_dev_start's invocation to start TX for
+		one queue. Refer to start_rx_per_q for the use case. */
+	uint8_t tx_enable_queue;
 };
 
 /**
-- 
1.8.4.2

  reply	other threads:[~2014-07-22  7:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22  7:47 [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue start/stop Ouyang Changchun
2014-07-22  7:47 ` Ouyang Changchun [this message]
2014-07-22 17:43   ` [dpdk-dev] [PATCH 1/3] ether: Update field name and description for queue start Stephen Hemminger
2014-07-22  7:47 ` [dpdk-dev] [PATCH 2/3] ixgbe: Rename field name for queue start in ixgbe PMD Ouyang Changchun
2014-07-22  7:47 ` [dpdk-dev] [PATCH 3/3] vhost: Update reference in user space vhost sample Ouyang Changchun
2014-07-22  9:37 ` [dpdk-dev] [PATCH 0/3] Rename field name for RX/TX queue start/stop Thomas Monjalon
2014-07-22  9:52   ` Chen, Jing D
2014-07-23  1:07     ` Ouyang, Changchun
2014-07-28  4:34   ` Ouyang, Changchun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406015252-27804-2-git-send-email-changchun.ouyang@intel.com \
    --to=changchun.ouyang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).