From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2254F68AE for ; Tue, 22 Jul 2014 09:46:29 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 22 Jul 2014 00:42:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,708,1400050800"; d="scan'208";a="547048178" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by orsmga001.jf.intel.com with ESMTP; 22 Jul 2014 00:47:46 -0700 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shvmail01.sh.intel.com with ESMTP id s6M7lhuc011822; Tue, 22 Jul 2014 15:47:43 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id s6M7ldmr027912; Tue, 22 Jul 2014 15:47:41 +0800 Received: (from couyang@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id s6M7ldwe027908; Tue, 22 Jul 2014 15:47:39 +0800 From: Ouyang Changchun To: dev@dpdk.org Date: Tue, 22 Jul 2014 15:47:30 +0800 Message-Id: <1406015252-27804-2-git-send-email-changchun.ouyang@intel.com> X-Mailer: git-send-email 1.7.0.7 In-Reply-To: <1406015252-27804-1-git-send-email-changchun.ouyang@intel.com> References: <1406015252-27804-1-git-send-email-changchun.ouyang@intel.com> Subject: [dpdk-dev] [PATCH 1/3] ether: Update field name and description for queue start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2014 07:46:30 -0000 Rename the field name from start_rx_per_q to rx_enable_queue in struct rte_eth_rxconf, and do same thing for TX. This patch also update description for field rx_enable_queue and tx_enable_queue. Signed-off-by: Ouyang Changchun --- lib/librte_ether/rte_ethdev.h | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 50df654..a452810 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -604,7 +604,16 @@ struct rte_eth_rxconf { struct rte_eth_thresh rx_thresh; /**< RX ring threshold registers. */ uint16_t rx_free_thresh; /**< Drives the freeing of RX descriptors. */ uint8_t rx_drop_en; /**< Drop packets if no descriptors are available. */ - uint8_t start_rx_per_q; /**< start rx per queue. */ + /**< If rx_enable_queue is true, rte_eth_dev_rx_queue_start must be + invocated after rte_eth_dev_start's invocation to start RX for + one queue, and rte_eth_dev_rx_queue_start instead of + rte_eth_dev_start is responsible for allocating mbuf from + mempool and setup the DMA physical address. It is useful in + such scenario: buffer address is not available at the point of + rte_eth_dev_start's invocation but available later, e.g. in + VHOST zero copy case, the buffer address to be setup DMA + address is available only after one VM startup. */ + uint8_t rx_enable_queue; }; #define ETH_TXQ_FLAGS_NOMULTSEGS 0x0001 /**< nb_segs=1 for all mbufs */ @@ -625,7 +634,10 @@ struct rte_eth_txconf { uint16_t tx_rs_thresh; /**< Drives the setting of RS bit on TXDs. */ uint16_t tx_free_thresh; /**< Drives the freeing of TX buffers. */ uint32_t txq_flags; /**< Set flags for the Tx queue */ - uint8_t start_tx_per_q; /**< start tx per queue. */ + /**< If tx_enable_queue is true, rte_eth_dev_tx_queue_start must be + invocated after rte_eth_dev_start's invocation to start TX for + one queue. Refer to start_rx_per_q for the use case. */ + uint8_t tx_enable_queue; }; /** -- 1.8.4.2