From: Yerden Zhumabekov <e_zhumabekov@sts.kz>
To: <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH] igb_uio: fall back to enable/disable irq mode
Date: Wed, 23 Jul 2014 09:38:46 +0600 [thread overview]
Message-ID: <1406086726-54032-2-git-send-email-e_zhumabekov@sts.kz> (raw)
In-Reply-To: <1406086726-54032-1-git-send-email-e_zhumabekov@sts.kz>
Rewritten IRQ mode handling code introduced in commit 399a3f0d
(igb_uio: fix IRQ mode handling) renders some faulty NICs (VMware
e1000, for example) unusable if INTX mode is not supported.
This patch gets these NICs up and running, but throwing a kernel
warning.
Signed-off-by: Yerden Zhumabekov <e_zhumabekov@sts.kz>
---
lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
index f220a12..c4ab01a 100644
--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
@@ -620,9 +620,9 @@ igbuio_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
udev->info.irq_flags = IRQF_SHARED;
udev->mode = RTE_INTR_MODE_LEGACY;
} else {
- dev_err(&dev->dev, "PCI INTX mask not supported\n");
- err = -EIO;
- goto fail_release_iomem;
+ dev_warn(&dev->dev, "PCI INTX mask not supported\n");
+ udev->info.irq_flags = IRQF_SHARED;
+ udev->mode = RTE_INTR_MODE_LEGACY;
}
break;
default:
--
1.7.10.4
next prev parent reply other threads:[~2014-07-23 3:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 3:38 [dpdk-dev] [PATCH] igb_uio dropped support for some faulty NICs Yerden Zhumabekov
2014-07-23 3:38 ` Yerden Zhumabekov [this message]
2014-07-23 18:07 ` [dpdk-dev] [PATCH] igb_uio: fall back to enable/disable irq mode Stephen Hemminger
2014-07-23 18:09 ` Stephen Hemminger
2014-07-24 3:11 ` Yerden Zhumabekov
2014-07-24 15:11 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406086726-54032-2-git-send-email-e_zhumabekov@sts.kz \
--to=e_zhumabekov@sts.kz \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).