From: Neil Horman <nhorman@tuxdriver.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 1/2] ixgbe: test sse4.2 support at runtime for vectorized receive operations
Date: Wed, 30 Jul 2014 10:49:28 -0400 [thread overview]
Message-ID: <1406731769-18523-2-git-send-email-nhorman@tuxdriver.com> (raw)
In-Reply-To: <1406731769-18523-1-git-send-email-nhorman@tuxdriver.com>
The ixgbe vector receive code uses the sse4.2 intrinsics directly. Instead of
requiring that they be enabled at build time for the entire dpdk library, just
enable sse4.2 for the ixgbe_rxtx_vec.c file, and test for support at runtime
when using it
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Thomas Monjalon <thomas.monjalon@6wind.com>
---
lib/librte_pmd_ixgbe/Makefile | 6 ++++++
lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 5 +++++
2 files changed, 11 insertions(+)
diff --git a/lib/librte_pmd_ixgbe/Makefile b/lib/librte_pmd_ixgbe/Makefile
index 00ccedb..c002239 100644
--- a/lib/librte_pmd_ixgbe/Makefile
+++ b/lib/librte_pmd_ixgbe/Makefile
@@ -39,6 +39,12 @@ LIB = librte_pmd_ixgbe.a
CFLAGS += -O3
CFLAGS += $(WERROR_FLAGS)
+#
+# the vectorized recieve functions need sse4.2 instruction
+# intrinsics, make sure we emit them from the compiler
+#
+CFLAGS_ixgbe_rxtx_vec.o += -msse4.2
+
ifeq ($(CC), icc)
#
# CFLAGS for icc
diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
index 09e19a3..18e8bfe 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
@@ -34,6 +34,7 @@
#include <stdint.h>
#include <rte_ethdev.h>
#include <rte_malloc.h>
+#include <rte_cpuflags.h>
#include "ixgbe_ethdev.h"
#include "ixgbe_rxtx.h"
@@ -679,6 +680,10 @@ int ixgbe_rx_vec_condition_check(struct rte_eth_dev *dev)
struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
struct rte_fdir_conf *fconf = &dev->data->dev_conf.fdir_conf;
+ if (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_2)) {
+ RTE_LOG(ERR, PMD, "ixgbe vector rx needs sse4.2!\n");
+ return -1;
+ }
#ifndef RTE_IXGBE_RX_OLFLAGS_ENABLE
/* whithout rx ol_flags, no VP flag report */
if (rxmode->hw_vlan_strip != 0 ||
--
1.8.3.1
next prev parent reply other threads:[~2014-07-30 14:48 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 20:24 [dpdk-dev] [PATCH 0/2] dpdk: Allow for dynamic enablement of some isolated features Neil Horman
2014-07-29 20:24 ` [dpdk-dev] [PATCH 1/2] ixgbe: test sse4.2 support at runtime for vectorized receive operations Neil Horman
2014-07-29 20:24 ` [dpdk-dev] [PATCH 2/2] acl: Preform dynamic sse4.2 support check Neil Horman
2014-07-30 12:07 ` [dpdk-dev] [PATCH 0/2] dpdk: Allow for dynamic enablement of some isolated features Ananyev, Konstantin
2014-07-30 13:01 ` Neil Horman
2014-07-30 13:44 ` Ananyev, Konstantin
2014-07-30 14:49 ` [dpdk-dev] [PATCH v2 " Neil Horman
2014-07-30 14:49 ` Neil Horman [this message]
2014-07-30 14:49 ` [dpdk-dev] [PATCH v2 2/2] acl: Preform dynamic sse4.2 support check Neil Horman
2014-07-30 15:36 ` [dpdk-dev] [PATCH v2 0/2] dpdk: Allow for dynamic enablement of some isolated features Ananyev, Konstantin
2014-07-30 19:03 ` Venky Venkatesan
2014-07-30 19:17 ` Neil Horman
2014-07-30 19:34 ` Neil Horman
2014-07-30 18:59 ` [dpdk-dev] [PATCH " Bruce Richardson
2014-07-30 19:28 ` Neil Horman
2014-07-30 21:09 ` Bruce Richardson
2014-07-31 9:30 ` Thomas Monjalon
2014-07-31 11:36 ` Ananyev, Konstantin
2014-07-31 13:13 ` Neil Horman
2014-07-31 13:26 ` Thomas Monjalon
2014-07-31 14:32 ` Neil Horman
2014-07-31 18:10 ` Neil Horman
2014-07-31 18:36 ` Bruce Richardson
2014-07-31 19:01 ` Neil Horman
2014-07-31 20:19 ` Bruce Richardson
2014-08-01 13:36 ` Neil Horman
2014-08-01 13:56 ` Ananyev, Konstantin
2014-08-01 14:26 ` Venkatesan, Venky
2014-08-01 14:27 ` Neil Horman
2014-07-31 19:58 ` John W. Linville
2014-07-31 20:20 ` Bruce Richardson
2014-07-31 20:32 ` John W. Linville
2014-08-01 8:46 ` Vincent JARDIN
2014-08-01 14:06 ` Neil Horman
2014-08-01 14:57 ` Vincent JARDIN
2014-08-01 15:19 ` Neil Horman
2014-07-31 20:10 ` Neil Horman
2014-07-31 20:25 ` Bruce Richardson
2014-08-01 15:06 ` Neil Horman
2014-08-01 19:22 ` Bruce Richardson
2014-08-01 20:43 ` Neil Horman
2014-08-01 21:08 ` Bruce Richardson
2014-08-02 12:56 ` Neil Horman
2014-07-31 21:53 ` Thomas Monjalon
2014-07-31 21:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406731769-18523-2-git-send-email-nhorman@tuxdriver.com \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).