From: Heng Ding <hengx.ding@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] i40e: Enable multicast promiscuous mode when promiscuous mode enabled for i40e driver
Date: Fri, 15 Aug 2014 09:47:32 +0800 [thread overview]
Message-ID: <1408067252-14179-1-git-send-email-hengx.ding@intel.com> (raw)
From: Ding Heng <hengx.ding@intel.com>
IPv6 will run NDP with multicast packets, but multicast packets will be
filtered by i40e driver by default. So we need to enable multicast when
promiscuous mode is on, or IPv6 will fail on these cards when running
testpmd and kni app.
Signed-off-by: Ding Heng <hengx.ding@intel.com>
---
lib/librte_pmd_i40e/i40e_ethdev.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index 9ed31b5..539dae5 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -755,6 +755,12 @@ i40e_dev_promiscuous_enable(struct rte_eth_dev *dev)
true, NULL);
if (status != I40E_SUCCESS)
PMD_DRV_LOG(ERR, "Failed to enable unicast promiscuous\n");
+
+ status = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid,
+ TRUE, NULL);
+ if (status != I40E_SUCCESS)
+ PMD_DRV_LOG(ERR, "Failed to enable multicast promiscuous\n");
+
}
static void
@@ -769,6 +775,11 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev)
false, NULL);
if (status != I40E_SUCCESS)
PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous\n");
+
+ status = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid,
+ false, NULL);
+ if (status != I40E_SUCCESS)
+ PMD_DRV_LOG(ERR, "Failed to disable multicast promiscuous\n");
}
static void
@@ -792,6 +803,9 @@ i40e_dev_allmulticast_disable(struct rte_eth_dev *dev)
struct i40e_vsi *vsi = pf->main_vsi;
int ret;
+ if (dev->data->promiscuous == 1)
+ return; /* must remain in all_multicast mode */
+
ret = i40e_aq_set_vsi_multicast_promiscuous(hw,
vsi->seid, FALSE, NULL);
if (ret != I40E_SUCCESS)
--
1.9.3
next reply other threads:[~2014-08-15 1:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 1:47 Heng Ding [this message]
2014-08-15 1:49 ` Zhang, Helin
2014-08-25 14:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408067252-14179-1-git-send-email-hengx.ding@intel.com \
--to=hengx.ding@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).