From: <zhang.zhangkun@huawei.com>
To: <dev@dpdk.org>
Cc: zhangkun <zhangk.zhangkun@huawei.com>
Subject: [dpdk-dev] [PATCH] there are some memory leak about Dir operator
Date: Tue, 19 Aug 2014 11:51:11 +0800 [thread overview]
Message-ID: <1408420271-11568-1-git-send-email-zhang.zhangkun@huawei.com> (raw)
From: zhangkun <zhangk.zhangkun@huawei.com>
Signed-off-by: zhangkun <zhangk.zhangkun@huawei.com>
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
index b72a205..d784b7c 100644
--- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
+++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
@@ -311,12 +311,14 @@ eal_hugepage_info_init(void)
/* if blocking lock failed */
if (flock(hpi->lock_descriptor, LOCK_EX) == -1) {
RTE_LOG(CRIT, EAL, "Failed to lock hugepage directory!\n");
+ closedir(dir);
return -1;
}
/* clear out the hugepages dir from unused pages */
- if (clear_hugedir(hpi->hugedir) == -1)
+ if (clear_hugedir(hpi->hugedir) == -1) {
+ closedir(dir);
return -1;
-
+ }
/* for now, put all pages into socket 0,
* later they will be sorted */
hpi->num_pages[0] = get_num_hugepages(dirent->d_name);
--
1.7.3.1.msysgit.0
next reply other threads:[~2014-08-19 3:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 3:51 zhang.zhangkun [this message]
2014-08-29 10:43 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2014-08-19 3:39 zhang.zhangkun
2014-08-19 3:53 ` Zhang, Helin
2014-08-19 6:10 ` [dpdk-dev] 答复: " Zhangkun (K)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408420271-11568-1-git-send-email-zhang.zhangkun@huawei.com \
--to=zhang.zhangkun@huawei.com \
--cc=dev@dpdk.org \
--cc=zhangk.zhangkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).