From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 453B168CD for ; Mon, 1 Sep 2014 12:20:20 +0200 (CEST) Received: by mail-wg0-f41.google.com with SMTP id l18so5117031wgh.0 for ; Mon, 01 Sep 2014 03:24:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=6ffVSOirGJb45l2VWkVylJrZGCq4StiXsLhBlEcSwGk=; b=YUQZwkNhfj98+KiRy+ETn3B/YAe6KK3NLnidORGi/N+VsaMtgpL22o49y7GFIkzCgZ rtdA4sxytaNowZM0U9ubqVI0y+tw08q/VygbSkqxQCBvMw20J2/IRWqTMb5PTCJx9qhK nHw6vHrc13iMjfJ2kz22QVDAEfDea7Q/Nl0bUAeBH8f2tr4120KDLeRD3rr8hXdDvXgK xCYyMWGwl/vrMUJM20Sgt7XkP7biXgl2ofkHpsIMsT2RL/kKjVBgrrnz1uN/C1tQKEKY imYlJWpVszP1VoAaAI1l252wP0xeeQNayPQGkUEz+h8OOTKuRnFMeXQ32LuOIE1f5xUY xJOg== X-Gm-Message-State: ALoCoQm5KLSMM0c0wAVKr0T8MFHSz07q4kMbH8nvvmiSDubN78IKm7uDVnMg/ChZNmdu8PaaQ00L X-Received: by 10.194.187.241 with SMTP id fv17mr31531480wjc.13.1409567087131; Mon, 01 Sep 2014 03:24:47 -0700 (PDT) Received: from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id lm18sm24287018wic.22.2014.09.01.03.24.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Sep 2014 03:24:46 -0700 (PDT) From: David Marchand To: dev@dpdk.org Date: Mon, 1 Sep 2014 12:24:23 +0200 Message-Id: <1409567080-27083-1-git-send-email-david.marchand@6wind.com> X-Mailer: git-send-email 1.7.10.4 Subject: [dpdk-dev] [PATCH v2 00/17] cleanup logs in main PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Sep 2014 10:20:20 -0000 Here is a patchset that reworks the log macro in e1000, ixgbe and i40e PMDs. The idea behind this is to make it easier to debug some init failures and to be sure of the datapath selected in these PMDs (rx / tx handlers selection). The PMDs changes involve adding more debug messages in the default build. A new eal option has been added to set the default log level, so that you can render the eal a little less noisy. I did not change the default log level for now, as some eal log messages are marked as DEBUG while being interesting (from my point of view). I suppose we can change the default log level later once the eal has been cleaned up. Changes since v2: - continue clean up by always using PMD_*_LOG when logging something in PMD (i.e. no more printf, RTE_LOG, DEBUGOUT) - introduce PMD_DRV_LOG_RAW macro for use by shared driver code - adopt 'second approach': no more \n in PMD_*_LOG callers. This means that we will enforce a 'no \n' policy in logs for PMD. -- David Marchand David Marchand (17): ixgbe: use the right debug macro ixgbe/base: add a _RAW macro for use by shared code ixgbe: clean log messages ixgbe: always log init messages ixgbe: add a message when forcing scatter mode ixgbe: add log messages when rx bulk mode is not usable i40e: use the right debug macro i40e/base: add a _RAW macro for use by shared code i40e: clean log messages i40e: always log init messages i40e: add log messages when rx bulk mode is not usable e1000: use the right debug macro e1000/base: add a _RAW macro for use by shared code e1000: clean log messages e1000: always log init messages e1000: add a message when forcing scatter mode eal: set log level from command line lib/librte_eal/bsdapp/eal/eal.c | 42 ++ .../bsdapp/eal/include/eal_internal_cfg.h | 1 + lib/librte_eal/linuxapp/eal/eal.c | 44 +- .../linuxapp/eal/include/eal_internal_cfg.h | 1 + lib/librte_pmd_e1000/e1000/e1000_osdep.h | 4 +- lib/librte_pmd_e1000/e1000_logs.h | 18 +- lib/librte_pmd_e1000/em_ethdev.c | 64 ++- lib/librte_pmd_e1000/em_rxtx.c | 137 +++--- lib/librte_pmd_e1000/igb_ethdev.c | 100 +++-- lib/librte_pmd_e1000/igb_pf.c | 5 +- lib/librte_pmd_e1000/igb_rxtx.c | 69 ++-- lib/librte_pmd_i40e/i40e/i40e_osdep.h | 8 +- lib/librte_pmd_i40e/i40e_ethdev.c | 434 ++++++++++---------- lib/librte_pmd_i40e/i40e_ethdev_vf.c | 168 ++++---- lib/librte_pmd_i40e/i40e_logs.h | 16 +- lib/librte_pmd_i40e/i40e_pf.c | 79 ++-- lib/librte_pmd_i40e/i40e_rxtx.c | 201 +++++---- lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h | 4 +- lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c | 14 +- lib/librte_pmd_ixgbe/ixgbe_bypass.c | 26 +- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 177 ++++---- lib/librte_pmd_ixgbe/ixgbe_fdir.c | 6 +- lib/librte_pmd_ixgbe/ixgbe_logs.h | 16 +- lib/librte_pmd_ixgbe/ixgbe_pf.c | 4 +- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 169 +++++--- 25 files changed, 979 insertions(+), 828 deletions(-) -- 1.7.10.4