From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 96E79B399 for ; Tue, 9 Sep 2014 09:16:58 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 09 Sep 2014 00:22:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,491,1406617200"; d="scan'208";a="596669317" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by fmsmga002.fm.intel.com with ESMTP; 09 Sep 2014 00:21:59 -0700 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shvmail01.sh.intel.com with ESMTP id s897Lwwf008484; Tue, 9 Sep 2014 15:21:58 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id s897LumM004453; Tue, 9 Sep 2014 15:21:58 +0800 Received: (from hzhan75@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id s897LtZY004449; Tue, 9 Sep 2014 15:21:55 +0800 From: Helin Zhang To: dev@dpdk.org Date: Tue, 9 Sep 2014 15:21:28 +0800 Message-Id: <1410247299-4365-5-git-send-email-helin.zhang@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1410247299-4365-1-git-send-email-helin.zhang@intel.com> References: <1410247299-4365-1-git-send-email-helin.zhang@intel.com> Subject: [dpdk-dev] [PATCH 04/15] i40e: remove test code for 'ethtool' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Sep 2014 07:16:59 -0000 The code wrapped in '#ifdef ETHTOOL_TEST' in i40e_diag.c is for ethtool testing only, it is not needed anymore and can be removed. Signed-off-by: Helin Zhang Reviewed-by: Chen Jing --- lib/librte_pmd_i40e/i40e/i40e_diag.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e/i40e_diag.c b/lib/librte_pmd_i40e/i40e/i40e_diag.c index f24bf81..167fcf8 100644 --- a/lib/librte_pmd_i40e/i40e/i40e_diag.c +++ b/lib/librte_pmd_i40e/i40e/i40e_diag.c @@ -71,11 +71,6 @@ static enum i40e_status_code i40e_diag_reg_pattern_test(struct i40e_hw *hw, wr32(hw, reg, (pat & mask)); val = rd32(hw, reg); if ((val & mask) != (pat & mask)) { -#ifdef ETHTOOL_TEST - i40e_debug(hw, I40E_DEBUG_DIAG, - "%s: reg pattern test failed - reg 0x%08x pat 0x%08x val 0x%08x\n", - __func__, reg, pat, val); -#endif return I40E_ERR_DIAG_TEST_FAILED; } } @@ -83,11 +78,6 @@ static enum i40e_status_code i40e_diag_reg_pattern_test(struct i40e_hw *hw, wr32(hw, reg, orig_val); val = rd32(hw, reg); if (val != orig_val) { -#ifdef ETHTOOL_TEST - i40e_debug(hw, I40E_DEBUG_DIAG, - "%s: reg restore test failed - reg 0x%08x orig_val 0x%08x val 0x%08x\n", - __func__, reg, orig_val, val); -#endif return I40E_ERR_DIAG_TEST_FAILED; } -- 1.8.1.4