From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 537F3A053A; Wed, 5 Aug 2020 10:27:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 590D41BFF5; Wed, 5 Aug 2020 10:27:36 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 684B329D2 for ; Wed, 5 Aug 2020 10:27:35 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id F03645804E8; Wed, 5 Aug 2020 04:27:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 05 Aug 2020 04:27:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= pCnz7cm10teFx2S+wRPgFu3y/IF/MpPZ3SM8jQscz74=; b=h29U3cGXNS2xzj5q rjhOi/B4SvrbWDbwRvnbfiDoDOtR3QtKqBF7v0k3AWkwIqq5NVH0DQcMb+7mshgT J9f5EBWOtzc978tV3LrkGzJSgTpUkJbMuxWHBYYdO9acjTknGcCNfJBIT6fQXXBF lkeSkqIiNXqjDxz4StL7EwjqxfkEQxyxfXrHnpVFCQptiHcqzu4JdWTakWYR2vL0 U+6QQgvTbmP0bI3uBW/yTcM7hU4E5M4n6WDuF+qRrzbLONrrEC7e0Hrn+d+EnnBT kunQGLwFMFyvGp0s2qq8l3HCdryYSTfyx34SkZRb/dxawLE4VZn160fgcd/QITP4 duJpLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=pCnz7cm10teFx2S+wRPgFu3y/IF/MpPZ3SM8jQscz 74=; b=dm+pf6RgOk5WST/L4/VrMay6LAhJn+0+kD+9E10C8L1HGx8PocZ2xBVWm re6CSfEGi3M7x385RgZmUep9bdKEdHp4lAQicXUIAZoi4e4i0w7HmpnyGCwC8UP1 f22RAjQvfB785WzGEyRGQTOEJSTlrpcTnl5oCc5Oi/I8NYflTj7uDrtRySL04ajt Wr5hXWnp/UG5VVxK/C42y/6FEQ6I5uvedfD+D1RWKHfQUCRW5vFl0v1nJPCoXbIJ 0WlRJaD0lWuSOxWtO8Za5NtI8Gh3kZK1HJWgCsJsO3YKE9bxJFPJmoMbx8P/mDCl yMvv8f0nifVgpZKW88YW6ZJHpYz6A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 73D31328005E; Wed, 5 Aug 2020 04:27:29 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: Fady Bader , dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, kevin.laatz@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, ciara.power@intel.com, navasile@linux.microsoft.com Date: Wed, 05 Aug 2020 10:27:27 +0200 Message-ID: <14102736.rQ7LXLPuFW@thomas> In-Reply-To: <20200805023926.210646e2@sovereign> References: <20200625133038.25180-1-fady@mellanox.com> <20200804062947.6176-5-fady@mellanox.com> <20200805023926.210646e2@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 4/5] telemetry: implement empty stubs for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/08/2020 01:39, Dmitry Kozlyuk: > On Tue, 4 Aug 2020 09:29:46 +0300, Fady Bader wrote: > > Telemetry didn't compile under Windows. > > Empty stubs implementation was added for Windows. > > > > Signed-off-by: Fady Bader > > --- > > lib/librte_telemetry/rte_telemetry.h | 4 +++ > > lib/librte_telemetry/telemetry.c | 51 ++++++++++++++++++++++++++++++++- > > lib/librte_telemetry/telemetry_legacy.c | 26 ++++++++++++++++- > > 3 files changed, 79 insertions(+), 2 deletions(-) > > You could #ifdef code in librte_ethdev that uses librte_telemetry and not > build librte_telemetry at all. This approach is already taken in > eal_common_options.c and it avoids spreading #ifdef throughout telemetry code. The problem is that telemetry can be used anywhere, not only in ethdev. I feel it is better to #ifdef telemetry than every telemetry calls.