DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/3] eal: add core id param to eal_thread_set_affinity
Date: Thu, 11 Sep 2014 15:23:05 +0100
Message-ID: <1410445387-4849-2-git-send-email-bruce.richardson@intel.com> (raw)
In-Reply-To: <1410445387-4849-1-git-send-email-bruce.richardson@intel.com>

the function eal_thread_set_affinity always sets the affinity of the
thread to the lcore_id of the thread as given by the thread-local
variable. To allow this function to be used by arbitrary threads
(e.g. eal utility threads such as those for interrupts, timers, etc.),
add a parameter to specify the core id to be used for the affinity.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_eal/bsdapp/eal/eal_thread.c   | 10 +++++-----
 lib/librte_eal/linuxapp/eal/eal_thread.c | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c b/lib/librte_eal/bsdapp/eal/eal_thread.c
index ab05368..18df2a3 100644
--- a/lib/librte_eal/bsdapp/eal/eal_thread.c
+++ b/lib/librte_eal/bsdapp/eal/eal_thread.c
@@ -96,7 +96,7 @@ rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned slave_id)
 
 /* set affinity for current thread */
 static int
-eal_thread_set_affinity(void)
+eal_thread_set_affinity(unsigned lcore_id)
 {
 	int s;
 	pthread_t thread;
@@ -126,7 +126,7 @@ eal_thread_set_affinity(void)
 
 	size = CPU_ALLOC_SIZE(RTE_MAX_LCORE);
 	CPU_ZERO_S(size, cpusetp);
-	CPU_SET_S(rte_lcore_id(), size, cpusetp);
+	CPU_SET_S(lcore_id, size, cpusetp);
 
 	thread = pthread_self();
 	s = pthread_setaffinity_np(thread, size, cpusetp);
@@ -140,7 +140,7 @@ eal_thread_set_affinity(void)
 #else /* CPU_ALLOC */
 	cpuset_t cpuset;
 	CPU_ZERO( &cpuset );
-	CPU_SET( rte_lcore_id(), &cpuset );
+	CPU_SET(lcore_id, &cpuset );
 
 	thread = pthread_self();
 	s = pthread_setaffinity_np(thread, sizeof( cpuset ), &cpuset);
@@ -158,7 +158,7 @@ void eal_thread_init_master(unsigned lcore_id)
 	RTE_PER_LCORE(_lcore_id) = lcore_id;
 
 	/* set CPU affinity */
-	if (eal_thread_set_affinity() < 0)
+	if (eal_thread_set_affinity(lcore_id) < 0)
 		rte_panic("cannot set affinity\n");
 }
 
@@ -192,7 +192,7 @@ eal_thread_loop(__attribute__((unused)) void *arg)
 	RTE_PER_LCORE(_lcore_id) = lcore_id;
 
 	/* set CPU affinity */
-	if (eal_thread_set_affinity() < 0)
+	if (eal_thread_set_affinity(lcore_id) < 0)
 		rte_panic("cannot set affinity\n");
 
 	/* read on our pipe to get commands */
diff --git a/lib/librte_eal/linuxapp/eal/eal_thread.c b/lib/librte_eal/linuxapp/eal/eal_thread.c
index 80a985f..9dc3f98 100644
--- a/lib/librte_eal/linuxapp/eal/eal_thread.c
+++ b/lib/librte_eal/linuxapp/eal/eal_thread.c
@@ -96,7 +96,7 @@ rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned slave_id)
 
 /* set affinity for current thread */
 static int
-eal_thread_set_affinity(void)
+eal_thread_set_affinity(unsigned lcore_id)
 {
 	int s;
 	pthread_t thread;
@@ -126,7 +126,7 @@ eal_thread_set_affinity(void)
 
 	size = CPU_ALLOC_SIZE(RTE_MAX_LCORE);
 	CPU_ZERO_S(size, cpusetp);
-	CPU_SET_S(rte_lcore_id(), size, cpusetp);
+	CPU_SET_S(lcore_id, size, cpusetp);
 
 	thread = pthread_self();
 	s = pthread_setaffinity_np(thread, size, cpusetp);
@@ -140,7 +140,7 @@ eal_thread_set_affinity(void)
 #else /* CPU_ALLOC */
 	cpu_set_t cpuset;
 	CPU_ZERO( &cpuset );
-	CPU_SET( rte_lcore_id(), &cpuset );
+	CPU_SET(lcore_id, &cpuset);
 
 	thread = pthread_self();
 	s = pthread_setaffinity_np(thread, sizeof( cpuset ), &cpuset);
@@ -158,7 +158,7 @@ void eal_thread_init_master(unsigned lcore_id)
 	RTE_PER_LCORE(_lcore_id) = lcore_id;
 
 	/* set CPU affinity */
-	if (eal_thread_set_affinity() < 0)
+	if (eal_thread_set_affinity(lcore_id) < 0)
 		rte_panic("cannot set affinity\n");
 }
 
@@ -192,7 +192,7 @@ eal_thread_loop(__attribute__((unused)) void *arg)
 	RTE_PER_LCORE(_lcore_id) = lcore_id;
 
 	/* set CPU affinity */
-	if (eal_thread_set_affinity() < 0)
+	if (eal_thread_set_affinity(lcore_id) < 0)
 		rte_panic("cannot set affinity\n");
 
 	/* read on our pipe to get commands */
-- 
1.9.3

       reply	other threads:[~2014-09-11 14:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1410445387-4849-1-git-send-email-bruce.richardson@intel.com>
2014-09-11 14:23 ` Bruce Richardson [this message]
2014-09-11 14:23 ` [dpdk-dev] [PATCH 2/3] eal: increase scope of eal_thread_set_affinity Bruce Richardson
2014-09-11 14:23 ` [dpdk-dev] [PATCH 3/3] eal: affinitize low-priority threads to lcore 0 Bruce Richardson
2014-09-11 23:47 ` [dpdk-dev] [PATCH 0/3] eal affinitize low priority " Hiroshi Shimamoto
2014-09-12  1:24   ` Stephen Hemminger
2014-09-12  8:07   ` Richardson, Bruce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410445387-4849-2-git-send-email-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git