DPDK patches and discussions
 help / color / mirror / Atom feed
From: Helin Zhang <helin.zhang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/3] i40e: renaming some local variables
Date: Wed, 17 Sep 2014 15:54:19 +0800	[thread overview]
Message-ID: <1410940461-17509-2-git-send-email-helin.zhang@intel.com> (raw)
In-Reply-To: <1410940461-17509-1-git-send-email-helin.zhang@intel.com>

To be more straightforward, two local variables in interrupt
handler are renamed.

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
Reviewed-by: Jing Chen <jing.d.chen@intel.com>
Reviewed-by: Jijiang Liu <jijiang.liu@intel.com>
---
 lib/librte_pmd_i40e/i40e_ethdev.c | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index 4e65ca4..003b084 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -3391,53 +3391,53 @@ i40e_dev_interrupt_handler(__rte_unused struct rte_intr_handle *handle,
 {
 	struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
 	struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-	uint32_t cause, enable;
+	uint32_t icr0, icr0_ena;
 
 	i40e_pf_disable_irq0(hw);
 
-	cause = I40E_READ_REG(hw, I40E_PFINT_ICR0);
-	enable = I40E_READ_REG(hw, I40E_PFINT_ICR0_ENA);
+	icr0 = I40E_READ_REG(hw, I40E_PFINT_ICR0);
+	icr0_ena = I40E_READ_REG(hw, I40E_PFINT_ICR0_ENA);
 
 	/* Shared IRQ case, return */
-	if (!(cause & I40E_PFINT_ICR0_INTEVENT_MASK)) {
+	if (!(icr0 & I40E_PFINT_ICR0_INTEVENT_MASK)) {
 		PMD_DRV_LOG(INFO, "Port%d INT0:share IRQ case, "
 			"no INT event to process\n", hw->pf_id);
 		goto done;
 	}
 
-	if (cause & I40E_PFINT_ICR0_LINK_STAT_CHANGE_MASK) {
+	if (icr0 & I40E_PFINT_ICR0_LINK_STAT_CHANGE_MASK) {
 		PMD_DRV_LOG(INFO, "INT:Link status changed\n");
 		i40e_dev_link_update(dev, 0);
 	}
 
-	if (cause & I40E_PFINT_ICR0_ECC_ERR_MASK)
+	if (icr0 & I40E_PFINT_ICR0_ECC_ERR_MASK)
 		PMD_DRV_LOG(INFO, "INT:Unrecoverable ECC Error\n");
 
-	if (cause & I40E_PFINT_ICR0_MAL_DETECT_MASK)
+	if (icr0 & I40E_PFINT_ICR0_MAL_DETECT_MASK)
 		PMD_DRV_LOG(INFO, "INT:Malicious programming detected\n");
 
-	if (cause & I40E_PFINT_ICR0_GRST_MASK)
+	if (icr0 & I40E_PFINT_ICR0_GRST_MASK)
 		PMD_DRV_LOG(INFO, "INT:Global Resets Requested\n");
 
-	if (cause & I40E_PFINT_ICR0_PCI_EXCEPTION_MASK)
+	if (icr0 & I40E_PFINT_ICR0_PCI_EXCEPTION_MASK)
 		PMD_DRV_LOG(INFO, "INT:PCI EXCEPTION occured\n");
 
-	if (cause & I40E_PFINT_ICR0_HMC_ERR_MASK)
+	if (icr0 & I40E_PFINT_ICR0_HMC_ERR_MASK)
 		PMD_DRV_LOG(INFO, "INT:HMC error occured\n");
 
 	/* Add processing func to deal with VF reset vent */
-	if (cause & I40E_PFINT_ICR0_VFLR_MASK) {
+	if (icr0 & I40E_PFINT_ICR0_VFLR_MASK) {
 		PMD_DRV_LOG(INFO, "INT:VF reset detected\n");
 		i40e_dev_handle_vfr_event(dev);
 	}
 	/* Find admin queue event */
-	if (cause & I40E_PFINT_ICR0_ADMINQ_MASK) {
+	if (icr0 & I40E_PFINT_ICR0_ADMINQ_MASK) {
 		PMD_DRV_LOG(INFO, "INT:ADMINQ event\n");
 		i40e_dev_handle_aq_msg(dev);
 	}
 
 done:
-	I40E_WRITE_REG(hw, I40E_PFINT_ICR0_ENA, enable);
+	I40E_WRITE_REG(hw, I40E_PFINT_ICR0_ENA, icr0_ena);
 	/* Re-enable interrupt from device side */
 	i40e_pf_enable_irq0(hw);
 	/* Re-enable interrupt from host side */
-- 
1.8.1.4

  reply	other threads:[~2014-09-17  7:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17  7:54 [dpdk-dev] [PATCH 0/3] fix of lsc interrupt in i40e PF Helin Zhang
2014-09-17  7:54 ` Helin Zhang [this message]
2014-09-17  7:54 ` [dpdk-dev] [PATCH 2/3] i40e: rework of PF interrupt cause enable flags processing Helin Zhang
2014-09-17  7:54 ` [dpdk-dev] [PATCH 3/3] i40e: fix of interrupt based link status change Helin Zhang
2014-09-30  6:09 ` [dpdk-dev] [PATCH 0/3] fix of lsc interrupt in i40e PF Cao, Min
2014-10-10  1:48 ` Chen, Jing D
2014-11-03 17:19   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410940461-17509-2-git-send-email-helin.zhang@intel.com \
    --to=helin.zhang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).