From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
by dpdk.org (Postfix) with ESMTP id A7CC6B3D3
for <dev@dpdk.org>; Wed, 17 Sep 2014 15:41:41 +0200 (CEST)
Received: by mail-wg0-f52.google.com with SMTP id x13so1421407wgg.35
for <dev@dpdk.org>; Wed, 17 Sep 2014 06:47:22 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=bYD0lHabhGhlgO/tp/g/D0+hvcdB7Sa/VX4X1jVtadI=;
b=ibht3rWXahwsyY4guJ/eDOQNupoy2uF2LyEfZtnLJck6bUTeJ5OQ2MSw0yAJhfCjD8
f6RzwbEUdnTOGwass53JB9O0cyXffzgA+Q3xP3vPrnXsO883YU1GhEvjTNiNyxS6POGu
YIcXYGpSmR60f+n8sazkq3nbl1M93tFT4mF/3VV2weS8M6/4xKFlXO6ns0fYzRRAjAX6
ZRGA0AmX/UHfNm/gc7jBvw/XGm8PdACF05Pl1IwlB3+xhQEYxsdD559na3QUGu6i6IXS
m2+IgInfWI0Z9ZlwzwRTc0n+z9+dNAWHS89lm8qsK/zyr17WE52D2zTVS1e9QvmnlNu6
FMHw==
X-Gm-Message-State: ALoCoQlWGaeXflQx3SVbXNhMVerifKOcDKym0S7M3Sx+0ct9akJOrCBPTnz6n34kSsM/OMBc1uAi
X-Received: by 10.194.188.110 with SMTP id fz14mr4566639wjc.70.1410961642834;
Wed, 17 Sep 2014 06:47:22 -0700 (PDT)
Received: from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.
[82.239.227.177])
by mx.google.com with ESMTPSA id fa20sm5712872wic.1.2014.09.17.06.47.21
for <multiple recipients>
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Wed, 17 Sep 2014 06:47:22 -0700 (PDT)
From: David Marchand <david.marchand@6wind.com>
To: dev@dpdk.org
Date: Wed, 17 Sep 2014 15:46:44 +0200
Message-Id: <1410961612-8571-13-git-send-email-david.marchand@6wind.com>
X-Mailer: git-send-email 1.7.10.4
In-Reply-To: <1410961612-8571-1-git-send-email-david.marchand@6wind.com>
References: <1410961612-8571-1-git-send-email-david.marchand@6wind.com>
Subject: [dpdk-dev] [PATCH v3 12/20] i40e: always log init messages
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Sep 2014 13:41:43 -0000
'init' messages should always be logged and filtered at runtime by rte_log.
All the more so as these messages are not in the datapath.
Signed-off-by: David Marchand <david.marchand@6wind.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/librte_pmd_i40e/i40e_logs.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/librte_pmd_i40e/i40e_logs.h b/lib/librte_pmd_i40e/i40e_logs.h
index 043ecba..399867f 100644
--- a/lib/librte_pmd_i40e/i40e_logs.h
+++ b/lib/librte_pmd_i40e/i40e_logs.h
@@ -34,12 +34,13 @@
#ifndef _I40E_LOGS_H_
#define _I40E_LOGS_H_
-#ifdef RTE_LIBRTE_I40E_DEBUG_INIT
#define PMD_INIT_LOG(level, fmt, args...) \
- RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
+ rte_log(RTE_LOG_ ## level, RTE_LOGTYPE_PMD, \
+ "PMD: %s(): " fmt "\n", __func__, ##args)
+
+#ifdef RTE_LIBRTE_I40E_DEBUG_INIT
#define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>")
#else
-#define PMD_INIT_LOG(level, fmt, args...) do { } while(0)
#define PMD_INIT_FUNC_TRACE() do { } while(0)
#endif
--
1.7.10.4