From: Keith Wiles <keith.wiles@windriver.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] Move the error check inside __mempool_check_cookies()
Date: Sat, 4 Oct 2014 18:10:28 -0500 [thread overview]
Message-ID: <1412464229-125521-1-git-send-email-keith.wiles@windriver.com> (raw)
Three places check for the return value from __mempool_get_bulk to be zero
and then call the debug routine __mempool_check_cookies(). The test is
not required if moved into the debug routine. Minor cleanup and mostly
does not effect performance, unless the is not removed by the compiler
in the case where teh debug routine is not defined.
Signed-off-by: Keith Wiles <keith.wiles@windriver.com>
---
lib/librte_mempool/rte_mempool.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 597cf4f..154fdd4 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -325,6 +325,9 @@ static inline void __mempool_check_cookies(const struct rte_mempool *mp,
void *obj;
void **obj_table;
+ if ( n < 0 )
+ return;
+
/* Force to drop the "const" attribute. This is done only when
* DEBUG is enabled */
tmp = (void *) obj_table_const;
@@ -1029,8 +1032,7 @@ rte_mempool_mc_get_bulk(struct rte_mempool *mp, void **obj_table, unsigned n)
{
int ret;
ret = __mempool_get_bulk(mp, obj_table, n, 1);
- if (ret == 0)
- __mempool_check_cookies(mp, obj_table, n, 1);
+ __mempool_check_cookies(mp, obj_table, n, 1);
return ret;
}
@@ -1058,8 +1060,7 @@ rte_mempool_sc_get_bulk(struct rte_mempool *mp, void **obj_table, unsigned n)
{
int ret;
ret = __mempool_get_bulk(mp, obj_table, n, 0);
- if (ret == 0)
- __mempool_check_cookies(mp, obj_table, n, 1);
+ __mempool_check_cookies(mp, obj_table, n, 1);
return ret;
}
@@ -1091,8 +1092,7 @@ rte_mempool_get_bulk(struct rte_mempool *mp, void **obj_table, unsigned n)
int ret;
ret = __mempool_get_bulk(mp, obj_table, n,
!(mp->flags & MEMPOOL_F_SC_GET));
- if (ret == 0)
- __mempool_check_cookies(mp, obj_table, n, 1);
+ __mempool_check_cookies(mp, obj_table, n, 1);
return ret;
}
--
2.1.0
next reply other threads:[~2014-10-04 23:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-04 23:10 Keith Wiles [this message]
2014-10-04 23:10 ` [dpdk-dev] [PATCH 2/2] Adding the routines rte_pktmbuf_alloc_bulk() and rte_pktmbuf_free_bulk() Keith Wiles
2014-10-06 8:56 ` Richardson, Bruce
2014-10-06 14:50 ` Wiles, Roger Keith
2014-10-06 14:53 ` Bruce Richardson
2014-10-06 15:54 ` Ananyev, Konstantin
2014-10-06 16:13 ` Wiles, Roger Keith
2014-10-06 19:45 ` Wiles, Roger Keith
2014-10-06 20:07 ` Wiles, Roger Keith
2014-10-07 9:09 ` Ananyev, Konstantin
2014-10-07 14:22 ` Wiles, Roger Keith
2014-10-07 15:42 ` Ananyev, Konstantin
2014-10-07 15:56 ` Wiles, Roger Keith
2014-10-07 16:33 ` Ananyev, Konstantin
2014-10-04 23:17 ` [dpdk-dev] [PATCH 1/2] Move the error check inside __mempool_check_cookies() Wiles, Roger Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412464229-125521-1-git-send-email-keith.wiles@windriver.com \
--to=keith.wiles@windriver.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).