From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2] Pass CC option when building kernel modules
Date: Thu, 9 Oct 2014 11:08:33 +0100 [thread overview]
Message-ID: <1412849313-5958-1-git-send-email-sergio.gonzalez.monroy@intel.com> (raw)
In-Reply-To: <1412611022-8278-1-git-send-email-sergio.gonzalez.monroy@intel.com>
At least on kernels 3.15 or newer, wrong compiler flags are set when building
kernel modules.
v2:
Remove unnecessary reset of CC when being included from the kernel.
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---
mk/rte.module.mk | 2 +-
mk/toolchain/clang/rte.vars.mk | 5 +----
mk/toolchain/gcc/rte.vars.mk | 1 +
mk/toolchain/icc/rte.vars.mk | 5 +----
4 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/mk/rte.module.mk b/mk/rte.module.mk
index c4ca3fd..41c0d0f 100644
--- a/mk/rte.module.mk
+++ b/mk/rte.module.mk
@@ -78,7 +78,7 @@ build: _postbuild
$(MODULE).ko: $(SRCS_LINKS)
@if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
@$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \
- CROSS_COMPILE=$(CROSS)
+ CC=$(KERNELCC) CROSS_COMPILE=$(CROSS)
# install module in $(RTE_OUTPUT)/kmod
$(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko
diff --git a/mk/toolchain/clang/rte.vars.mk b/mk/toolchain/clang/rte.vars.mk
index ee4f451..40cb389 100644
--- a/mk/toolchain/clang/rte.vars.mk
+++ b/mk/toolchain/clang/rte.vars.mk
@@ -38,11 +38,8 @@
# - define TOOLCHAIN_ASFLAGS variable (overriden by cmdline value)
#
-ifeq ($(KERNELRELEASE),)
CC = $(CROSS)clang
-else
-CC = $(CROSS)gcc
-endif
+KERNELCC = $(CROSS)gcc
CPP = $(CROSS)cpp
# for now, we don't use as but nasm.
# AS = $(CROSS)as
diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk
index 262ebdf..993eb26 100644
--- a/mk/toolchain/gcc/rte.vars.mk
+++ b/mk/toolchain/gcc/rte.vars.mk
@@ -39,6 +39,7 @@
#
CC = $(CROSS)gcc
+KERNELCC = $(CROSS)gcc
CPP = $(CROSS)cpp
# for now, we don't use as but nasm.
# AS = $(CROSS)as
diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
index 612370d..f03a2a2 100644
--- a/mk/toolchain/icc/rte.vars.mk
+++ b/mk/toolchain/icc/rte.vars.mk
@@ -41,11 +41,8 @@
# Warning: we do not use CROSS environment variable as icc is mainly a
# x86->x86 compiler
-ifeq ($(KERNELRELEASE),)
CC = icc
-else
-CC = gcc
-endif
+KERNELCC = gcc
CPP = cpp
AS = nasm
AR = ar
--
1.9.3
next prev parent reply other threads:[~2014-10-09 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 15:57 [dpdk-dev] [PATCH] " Sergio Gonzalez Monroy
2014-10-06 16:12 ` Bruce Richardson
2014-10-08 17:15 ` Thomas Monjalon
2014-10-09 8:10 ` Bruce Richardson
2014-10-09 10:04 ` Sergio Gonzalez Monroy
2014-10-09 10:08 ` Sergio Gonzalez Monroy [this message]
2014-10-13 16:08 ` [dpdk-dev] [PATCH v2] " De Lara Guarch, Pablo
2014-10-15 14:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412849313-5958-1-git-send-email-sergio.gonzalez.monroy@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).