From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] mk: fix app linking for combined libs
Date: Thu, 23 Oct 2014 16:36:44 +0100 [thread overview]
Message-ID: <1414078604-1090-1-git-send-email-sergio.gonzalez.monroy@intel.com> (raw)
Building combined shared libraries results in applications being linked
against separeted/individual and combined libs altogether.
Link only against combined lib when the config option is enabled.
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---
mk/rte.app.mk | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 285b65c..45444af 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -217,6 +217,12 @@ endif
endif # plugins
+ifeq ($(RTE_BUILD_COMBINE_LIBS),y)
+LDLIBS = --whole-archive
+LDLIBS += --start-group
+LDLIBS += -l$(RTE_LIBNAME)
+endif
+
LDLIBS += $(EXECENV_LDLIBS)
LDLIBS += --end-group
@@ -240,10 +246,6 @@ build: _postbuild
exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))
-ifeq ($(RTE_BUILD_COMBINE_LIBS),y)
-LDLIBS += -l$(RTE_LIBNAME)
-endif
-
ifeq ($(LINK_USING_CC),1)
LDLIBS := $(call linkerprefix,$(LDLIBS))
LDFLAGS := $(call linkerprefix,$(LDFLAGS))
--
1.9.3
next reply other threads:[~2014-10-23 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 15:36 Sergio Gonzalez Monroy [this message]
2014-10-28 16:37 ` De Lara Guarch, Pablo
2014-11-28 15:55 ` Thomas Monjalon
2014-12-01 9:57 ` Gonzalez Monroy, Sergio
2014-12-01 10:35 ` Thomas Monjalon
2014-12-01 11:15 ` Gonzalez Monroy, Sergio
2014-12-08 14:53 ` [dpdk-dev] " Neil Horman
2014-12-16 16:02 ` Thomas Monjalon
2014-12-16 23:26 ` Hiroshi Shimamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414078604-1090-1-git-send-email-sergio.gonzalez.monroy@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).