DPDK patches and discussions
 help / color / mirror / Atom feed
From: Helin Zhang <helin.zhang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 1/2] i40e: do not use macros defined in i40e_register_x710_int.h
Date: Wed, 29 Oct 2014 15:09:30 +0800
Message-ID: <1414566571-25829-2-git-send-email-helin.zhang@intel.com> (raw)
In-Reply-To: <1414566571-25829-1-git-send-email-helin.zhang@intel.com>

As i40e_register_x710_int.h is for early hardware only and
should be removed finally, the macros defiend in it should
not be used. For those registers which is not defined, just
define it in code directly as workaround.

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
 lib/librte_pmd_i40e/i40e_ethdev.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

v2 changes:
* Added back writing the register of I40E_GLINT_CTL.
* Defined I40E_GLINT_CTL and its relevant,
  i40e_register_x710_int.h will be deleted.

diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index e1f581a..6f2ceb2 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -51,7 +51,6 @@
 #include <rte_eth_ctrl.h>
 #include "i40e_logs.h"
-#include "i40e/i40e_register_x710_int.h"
 #include "i40e/i40e_prototype.h"
 #include "i40e/i40e_adminq_cmd.h"
 #include "i40e/i40e_type.h"
@@ -609,6 +608,10 @@ i40e_vsi_queues_bind_intr(struct i40e_vsi *vsi)
 				msix_vect - 1), interval);
+#ifndef I40E_GLINT_CTL
+#define I40E_GLINT_CTL                     0x0003F800
 		/* Disable auto-mask on enabling of all none-zero  interrupt */

  reply	other threads:[~2014-10-29  7:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-23  6:01 [dpdk-dev] [PATCH 0/2] remove registers for early hardware only Helin Zhang
2014-10-23  6:01 ` [dpdk-dev] [PATCH 1/2] i40e: " Helin Zhang
2014-10-23  6:01 ` [dpdk-dev] [PATCH 2/2] i40e: code style fix Helin Zhang
2014-10-23  7:21 ` [dpdk-dev] [PATCH 0/2] remove registers for early hardware only Thomas Monjalon
2014-10-23  7:24   ` Thomas Monjalon
2014-10-23  7:27     ` Zhang, Helin
2014-10-23  7:31       ` Thomas Monjalon
2014-10-29  7:09 ` [dpdk-dev] [PATCH v2 " Helin Zhang
2014-10-29  7:09   ` Helin Zhang [this message]
2014-10-29  7:09   ` [dpdk-dev] [PATCH v2 2/2] i40e: remove i40e_register_x710_int.h Helin Zhang
2014-10-29  8:53   ` [dpdk-dev] [PATCH v2 0/2] remove registers for early hardware only Wu, Jingjing
2014-10-29 22:59     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414566571-25829-2-git-send-email-helin.zhang@intel.com \
    --to=helin.zhang@intel.com \
    --cc=dev@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git