From: Ouyang Changchun <changchun.ouyang@intel.com> To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v2] vhost: Fix packet length issue Date: Thu, 30 Oct 2014 22:59:36 +0800 Message-ID: <1414681176-13965-1-git-send-email-changchun.ouyang@intel.com> (raw) In-Reply-To: <1414659602-10115-1-git-send-email-changchun.ouyang@intel.com> As HW vlan strip will reduce the packet length by minus length of vlan tag, so it need restore the packet length by plus it. Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com> --- v2 change: Update data length by plus offset in first segment instead of last segment. v1 change: Update the packet length by plus offset. Use macro to replace constant; examples/vhost/main.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 0566124..9ed48fc 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/main.c @@ -1097,7 +1097,13 @@ virtio_tx_route(struct vhost_dev *vdev, struct rte_mbuf *m, uint16_t vlan_tag) rte_pktmbuf_free(m); return; } - offset = 4; + + /* + * HW vlan strip will reduce the packet length + * by minus length of vlan tag, so need restore + * the packet length by plus it. + */ + offset = VLAN_HLEN; vlan_tag = (uint16_t) vlan_tags[(uint16_t)dev_ll->vdev->dev->device_fh]; @@ -1121,8 +1127,10 @@ virtio_tx_route(struct vhost_dev *vdev, struct rte_mbuf *m, uint16_t vlan_tag) len = tx_q->len; m->ol_flags = PKT_TX_VLAN_PKT; - /*FIXME: offset*/ + m->data_len += offset; + m->pkt_len += offset; + m->vlan_tci = vlan_tag; tx_q->m_table[len] = m; -- 1.8.4.2
next prev parent reply other threads:[~2014-10-30 14:52 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-10-30 9:00 [dpdk-dev] [PATCH] " Ouyang Changchun 2014-10-30 14:59 ` Ouyang Changchun [this message] 2014-11-04 7:05 ` [dpdk-dev] [PATCH v3 0/2] " Ouyang Changchun 2014-11-04 7:05 ` [dpdk-dev] [PATCH v3 1/2] vhost: " Ouyang Changchun 2014-11-04 7:05 ` [dpdk-dev] [PATCH v3 2/2] vhost: Remove duplicated codes Ouyang Changchun 2014-11-05 7:10 ` [dpdk-dev] [PATCH v4 0/3] Fix packet length issue Ouyang Changchun 2014-11-05 7:10 ` [dpdk-dev] [PATCH v4 1/3] vhost: " Ouyang Changchun 2014-11-05 16:46 ` Xie, Huawei 2014-11-05 7:10 ` [dpdk-dev] [PATCH v4 2/3] vhost: Remove duplicated codes Ouyang Changchun 2014-11-05 7:10 ` [dpdk-dev] [PATCH v4 3/3] vhost: Check offset value Ouyang Changchun 2014-11-05 16:52 ` Xie, Huawei 2014-11-05 17:00 ` Thomas Monjalon 2014-11-05 17:05 ` Xie, Huawei 2014-11-06 0:44 ` Ouyang, Changchun 2014-11-05 9:28 ` [dpdk-dev] [PATCH v4 0/3] Fix packet length issue Ananyev, Konstantin 2014-11-05 22:07 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1414681176-13965-1-git-send-email-changchun.ouyang@intel.com \ --to=changchun.ouyang@intel.com \ --cc=dev@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git