DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] librte_ether:change rte_eth_mac_filter structure
@ 2014-10-31  2:26 Jijiang Liu
  2014-10-31  9:24 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Jijiang Liu @ 2014-10-31  2:26 UTC (permalink / raw)
  To: dev

As the filter type in i40e is defined enum type, so this patch changes the filter_type filed in the rte_eth_mac_filter for fixing the compilation error under ICC compiler. 

Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
---
 lib/librte_ether/rte_eth_ctrl.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_ctrl.h
index 14a739b..91a6b64 100644
--- a/lib/librte_ether/rte_eth_ctrl.h
+++ b/lib/librte_ether/rte_eth_ctrl.h
@@ -91,7 +91,7 @@ enum rte_mac_filter_type {
 struct rte_eth_mac_filter {
 	uint8_t is_vf; /**< 1 for VF, 0 for port dev */
 	uint16_t dst_id; /**<VF ID, available when is_vf is 1*/
-	uint16_t filter_type; /**< MAC filter type */
+	enum rte_mac_filter_type filter_type; /**< MAC filter type */
 	struct ether_addr mac_addr;
 };
 
-- 
1.7.7.6

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] librte_ether:change rte_eth_mac_filter structure
  2014-10-31  2:26 [dpdk-dev] [PATCH] librte_ether:change rte_eth_mac_filter structure Jijiang Liu
@ 2014-10-31  9:24 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2014-10-31  9:24 UTC (permalink / raw)
  To: Jijiang Liu; +Cc: dev

2014-10-31 10:26, Jijiang Liu:
> As the filter type in i40e is defined enum type, so this patch changes
> the filter_type filed in the rte_eth_mac_filter for fixing the compilation
> error under ICC compiler. 

Commit log is wrong. It's not because of i40e, it's only an API problem.
But I know you mix i40e and generic API.

> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>

> --- a/lib/librte_ether/rte_eth_ctrl.h
> +++ b/lib/librte_ether/rte_eth_ctrl.h
> @@ -91,7 +91,7 @@ enum rte_mac_filter_type {
>  struct rte_eth_mac_filter {
>  	uint8_t is_vf; /**< 1 for VF, 0 for port dev */
>  	uint16_t dst_id; /**<VF ID, available when is_vf is 1*/
> -	uint16_t filter_type; /**< MAC filter type */
> +	enum rte_mac_filter_type filter_type; /**< MAC filter type */
>  	struct ether_addr mac_addr;
>  };

I didn't catch this error during my review. That's why we need more eyes to
carefully review patches.

Acked and applied

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-31  9:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-31  2:26 [dpdk-dev] [PATCH] librte_ether:change rte_eth_mac_filter structure Jijiang Liu
2014-10-31  9:24 ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git