From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 0393E556D for ; Mon, 3 Nov 2014 12:02:06 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 03 Nov 2014 03:11:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,307,1413270000"; d="scan'208";a="630246009" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga002.jf.intel.com with ESMTP; 03 Nov 2014 03:11:17 -0800 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id sA3BBGYM015837; Mon, 3 Nov 2014 11:11:17 GMT Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id sA3BBGVh030350; Mon, 3 Nov 2014 11:11:16 GMT Received: (from bricha3@localhost) by sivswdev01.ir.intel.com with id sA3BBGoX030346; Mon, 3 Nov 2014 11:11:16 GMT From: Bruce Richardson To: dev@dpdk.org Date: Mon, 3 Nov 2014 11:11:16 +0000 Message-Id: <1415013076-30314-1-git-send-email-bruce.richardson@intel.com> X-Mailer: git-send-email 1.7.4.1 Subject: [dpdk-dev] [PATCH] ixgbe: fix icc issue with mbuf initializer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Nov 2014 11:02:07 -0000 When using Intel C++ compiler(icc) 14.0.1.106 or the older icc 13.x version, the mbuf initializer variable was not getting configured correctly, as the mb_def variable was not set correctly. This is due to an issue with icc (DPD200249565 which already been fixed in icc 14.0.2 and newer compiler release) where it incorrectly calculates the field offsets with initializers when zero-sized fields are used in a structure. To work around this, the code in ixgbe_rxq_vec_setup does not setup the fields using an initializer, but instead assigns the values individually in code NOTE: There is no performance impact to this change as the queue setup functions are not data-plane APIs, but are only used at app initialization. Signed-off-by: Bruce Richardson --- lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c index e813e43..b57c588 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c @@ -730,16 +730,15 @@ static struct ixgbe_txq_ops vec_txq_ops = { int ixgbe_rxq_vec_setup(struct igb_rx_queue *rxq) { - struct rte_mbuf mb_def = { - .nb_segs = 1, - .data_off = RTE_PKTMBUF_HEADROOM, -#ifdef RTE_MBUF_REFCNT - { .refcnt = 1, } -#endif - }; + struct rte_mbuf mb_def = { .buf_addr = 0 }; /* zeroed mbuf */ + mb_def.nb_segs = 1; + mb_def.data_off = RTE_PKTMBUF_HEADROOM; mb_def.buf_len = rxq->mb_pool->elt_size - sizeof(struct rte_mbuf); mb_def.port = rxq->port_id; +#ifdef RTE_MBUF_REFCNT + mb_def.refcnt = 1; +#endif rxq->mbuf_initializer = *((uint64_t *)&mb_def.rearm_data); return 0; } -- 1.9.3