DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ouyang Changchun <changchun.ouyang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v4 3/3] vhost: Check offset value
Date: Wed,  5 Nov 2014 15:10:35 +0800	[thread overview]
Message-ID: <1415171435-24252-4-git-send-email-changchun.ouyang@intel.com> (raw)
In-Reply-To: <1415171435-24252-1-git-send-email-changchun.ouyang@intel.com>

This patch checks the packet length offset value, and checks if the extra bytes inside buffer
cross page boundary.

Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
---
 examples/vhost/main.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 2916313..a93f7a0 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -1110,7 +1110,8 @@ virtio_tx_route(struct vhost_dev *vdev, struct rte_mbuf *m, uint16_t vlan_tag)
 	}
 
 	if (vm2vm_mode == VM2VM_HARDWARE) {
-		if (find_local_dest(dev, m, &offset, &vlan_tag) != 0) {
+		if (find_local_dest(dev, m, &offset, &vlan_tag) != 0 ||
+			offset > rte_pktmbuf_tailroom(m)) {
 			rte_pktmbuf_free(m);
 			return;
 		}
@@ -1896,7 +1897,9 @@ virtio_dev_tx_zcp(struct virtio_net *dev)
 
 		/* Buffer address translation. */
 		buff_addr = gpa_to_vva(dev, desc->addr);
-		phys_addr = gpa_to_hpa(vdev, desc->addr, desc->len, &addr_type);
+		/* Need check extra VLAN_HLEN size for inserting VLAN tag */
+		phys_addr = gpa_to_hpa(vdev, desc->addr, desc->len + VLAN_HLEN,
+			&addr_type);
 
 		if (likely(packet_success < (free_entries - 1)))
 			/* Prefetch descriptor index. */
-- 
1.8.4.2

  parent reply	other threads:[~2014-11-05  7:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30  9:00 [dpdk-dev] [PATCH] vhost: Fix packet length issue Ouyang Changchun
2014-10-30 14:59 ` [dpdk-dev] [PATCH v2] " Ouyang Changchun
2014-11-04  7:05   ` [dpdk-dev] [PATCH v3 0/2] " Ouyang Changchun
2014-11-04  7:05     ` [dpdk-dev] [PATCH v3 1/2] vhost: " Ouyang Changchun
2014-11-04  7:05     ` [dpdk-dev] [PATCH v3 2/2] vhost: Remove duplicated codes Ouyang Changchun
2014-11-05  7:10     ` [dpdk-dev] [PATCH v4 0/3] Fix packet length issue Ouyang Changchun
2014-11-05  7:10       ` [dpdk-dev] [PATCH v4 1/3] vhost: " Ouyang Changchun
2014-11-05 16:46         ` Xie, Huawei
2014-11-05  7:10       ` [dpdk-dev] [PATCH v4 2/3] vhost: Remove duplicated codes Ouyang Changchun
2014-11-05  7:10       ` Ouyang Changchun [this message]
2014-11-05 16:52         ` [dpdk-dev] [PATCH v4 3/3] vhost: Check offset value Xie, Huawei
2014-11-05 17:00           ` Thomas Monjalon
2014-11-05 17:05             ` Xie, Huawei
2014-11-06  0:44             ` Ouyang, Changchun
2014-11-05  9:28       ` [dpdk-dev] [PATCH v4 0/3] Fix packet length issue Ananyev, Konstantin
2014-11-05 22:07         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415171435-24252-4-git-send-email-changchun.ouyang@intel.com \
    --to=changchun.ouyang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).