From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1134-249.mail.aliyun.com (out1134-249.mail.aliyun.com [42.120.134.249]) by dpdk.org (Postfix) with ESMTP id B02137E75 for ; Thu, 6 Nov 2014 16:22:54 +0100 (CET) X-Alimail-AntiSpam: AC=CONTINUE; BC=0.05519839|-1; FP=0|0|0|0|0|-1|-1|-1; HT=r41g03043; MF=liang.xu@cinfotech.cn; PH=DS; RN=4; RT=4; SR=0; Received: from dev.SSG-140(mailfrom:liang.xu@cinfotech.cn ip:222.65.239.251) by smtp.aliyun-inc.com(10.147.11.25); Thu, 06 Nov 2014 23:32:18 +0800 From: lxu To: dev@dpdk.org Date: Thu, 6 Nov 2014 23:32:08 +0800 Message-Id: <1415287928-14513-1-git-send-email-liang.xu@cinfotech.cn> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1415193919-17361-1-git-send-email-liang.xu@cinfotech.cn> References: <1415193919-17361-1-git-send-email-liang.xu@cinfotech.cn> Subject: [dpdk-dev] [PATCH v5] eal: map uio resources after hugepages when the base_virtaddr is configured. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2014 15:22:55 -0000 Sorry, I'm learning the right way to send a patch by git. I have a multiple processes application. When start the secondary process, I got error message "EAL: pci_map_resource(): cannot mmap(11, 0x7ffff7fba000, 0x20000, 0x0): Bad file descriptor (0x7ffff7fb9000)". The secondary process links a lot of additional shared libraries, so the address 0x7ffff7fba000 had already be used. I had fixed similar hugepages mmap problems by base_virtaddr. So I believe the uio resource should be mapped into base_virtaddr at this situation. This patch try to fix it. Signed-off-by: lxu --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c index 7e62266..a2c9ab6 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c @@ -273,6 +273,24 @@ pci_get_uio_dev(struct rte_pci_device *dev, char *dstbuf, return uio_num; } +static inline const struct rte_memseg * +get_physmem_last(void) +{ + const struct rte_memseg * seg = rte_eal_get_physmem_layout(); + const struct rte_memseg * last = seg; + unsigned i = 0; + + for (i=0; iaddr == NULL) + break; + + if(seg->addr > last->addr) + last = seg; + + } + return last; +} + /* map the PCI resource of a PCI device in virtual memory */ int pci_uio_map_resource(struct rte_pci_device *dev) @@ -290,6 +308,13 @@ pci_uio_map_resource(struct rte_pci_device *dev) struct mapped_pci_resource *uio_res; struct pci_map *maps; + /* map uio resource into user required virtual address */ + static void * requested_addr; + if (internal_config.base_virtaddr && NULL == requested_addr) { + const struct rte_memseg * last = get_physmem_last(); + requested_addr = RTE_PTR_ADD(last->addr, last->len); + } + dev->intr_handle.fd = -1; dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN; @@ -371,10 +396,12 @@ pci_uio_map_resource(struct rte_pci_device *dev) if (maps[j].addr != NULL) fail = 1; else { - mapaddr = pci_map_resource(NULL, fd, (off_t)offset, + mapaddr = pci_map_resource(requested_addr, fd, (off_t)offset, (size_t)maps[j].size); if (mapaddr == NULL) fail = 1; + else if (NULL != requested_addr) + requested_addr = RTE_PTR_ADD(mapaddr, maps[j].size); } if (fail) { -- 1.9.1