From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] app, examples: remove references to drivers config
Date: Fri, 7 Nov 2014 13:48:32 +0100 [thread overview]
Message-ID: <1415364512-9918-1-git-send-email-thomas.monjalon@6wind.com> (raw)
In-Reply-To: <1404374093-29710-1-git-send-email-helin.zhang@intel.com>
These references to drivers break the layering isolation between
application and drivers.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
app/test-pmd/testpmd.c | 7 +------
examples/exception_path/main.c | 4 +---
examples/kni/main.c | 4 +---
3 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index f76406f..c373e3a 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1870,12 +1870,7 @@ main(int argc, char** argv)
nb_ports = (portid_t) rte_eth_dev_count();
if (nb_ports == 0)
- rte_exit(EXIT_FAILURE, "No probed ethernet devices - "
- "check that "
- "CONFIG_RTE_LIBRTE_IGB_PMD=y and that "
- "CONFIG_RTE_LIBRTE_EM_PMD=y and that "
- "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in your "
- "configuration file\n");
+ rte_exit(EXIT_FAILURE, "No probed ethernet devices\n");
set_def_fwd_config();
if (nb_lcores == 0)
diff --git a/examples/exception_path/main.c b/examples/exception_path/main.c
index 3f8b1fb..692383b 100644
--- a/examples/exception_path/main.c
+++ b/examples/exception_path/main.c
@@ -546,9 +546,7 @@ main(int argc, char** argv)
/* Get number of ports found in scan */
nb_sys_ports = rte_eth_dev_count();
if (nb_sys_ports == 0)
- FATAL_ERROR("No supported Ethernet devices found - check that "
- "CONFIG_RTE_LIBRTE_IGB_PMD=y and/or "
- "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file");
+ FATAL_ERROR("No supported Ethernet devices found");
/* Find highest port set in portmask */
for (high_port = (sizeof(ports_mask) * 8) - 1;
(high_port != 0) && !(ports_mask & (1 << high_port));
diff --git a/examples/kni/main.c b/examples/kni/main.c
index 1344a87..370ae1c 100644
--- a/examples/kni/main.c
+++ b/examples/kni/main.c
@@ -881,9 +881,7 @@ main(int argc, char** argv)
/* Get number of ports found in scan */
nb_sys_ports = rte_eth_dev_count();
if (nb_sys_ports == 0)
- rte_exit(EXIT_FAILURE, "No supported Ethernet devices found - "
- "check that CONFIG_RTE_LIBRTE_IGB_PMD=y and/or "
- "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file\n");
+ rte_exit(EXIT_FAILURE, "No supported Ethernet devices found\n");
/* Check if the configured port ID is valid */
for (i = 0; i < RTE_MAX_ETHPORTS; i++)
--
2.1.3
next prev parent reply other threads:[~2014-11-07 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 7:54 [dpdk-dev] [PATCH] i40e: warnings should include i40e in some example applications Helin Zhang
2014-10-11 8:31 ` Wu, Jingjing
2014-11-07 12:48 ` Thomas Monjalon
2014-11-07 12:48 ` Thomas Monjalon [this message]
2014-11-07 23:26 ` [dpdk-dev] [PATCH] app, examples: remove references to drivers config Zhang, Helin
2014-11-10 9:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415364512-9918-1-git-send-email-thomas.monjalon@6wind.com \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).