* [dpdk-dev] [PATCH] app/test-pmd: Use the new rss_hf size changed in 1.7
@ 2014-11-07 15:43 Jia Yu
2014-11-27 17:25 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Jia Yu @ 2014-11-07 15:43 UTC (permalink / raw)
To: dev
According to rss_hf definition in rte_eth_rss_conf, it shall be uint64 type.
Using uint16 will get truncated value, and cause incorrect output. This
fix corrected this issue.
Signed-off-by: Jia Yu <jyu@vmware.com>
---
app/test-pmd/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 9bc08f4..b34b0b2 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -804,7 +804,7 @@ port_rss_hash_conf_show(portid_t port_id, int show_rss_key)
{
struct rte_eth_rss_conf rss_conf;
uint8_t rss_key[10 * 4];
- uint16_t rss_hf;
+ uint64_t rss_hf;
uint8_t i;
int diag;
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] app/test-pmd: Use the new rss_hf size changed in 1.7
2014-11-07 15:43 [dpdk-dev] [PATCH] app/test-pmd: Use the new rss_hf size changed in 1.7 Jia Yu
@ 2014-11-27 17:25 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2014-11-27 17:25 UTC (permalink / raw)
To: Jia Yu; +Cc: dev
> According to rss_hf definition in rte_eth_rss_conf, it shall be uint64 type.
> Using uint16 will get truncated value, and cause incorrect output. This
> fix corrected this issue.
>
> Signed-off-by: Jia Yu <jyu@vmware.com>
Acked and applied.
--
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-27 17:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-07 15:43 [dpdk-dev] [PATCH] app/test-pmd: Use the new rss_hf size changed in 1.7 Jia Yu
2014-11-27 17:25 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).