From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 67ACF595B for ; Fri, 14 Nov 2014 17:53:44 +0100 (CET) Received: by mail-wg0-f43.google.com with SMTP id y10so20119430wgg.16 for ; Fri, 14 Nov 2014 09:03:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=Bh8v7KE+mwfoawNaynDX4M8MWOqUMV8kvh52HjLeteM=; b=mwGwxDwQFhXt03PiHsT6EVv8+DfPOMVAc/DvhekPsEnqIlHQw0YBP/2yR511hGTNw2 U7VYe4czKOr8vYH2KWOVJs3MxzfToXptmm3nSPeE8kbo6S+5NQkQm1YQ4YZoPXZFzOHM eGR9Ba2KIG4LM0v916cdUq1IDzdVtVHBlyqHww0hJ1Xb1EumPxLbMFscpUT/ZmsQiYsP tIYAlXtjrt6iXVXPZswoL90fuSRh64miBJkqSoZc7Mj81MB8sa5Dtg1m9POBN5nFkArJ fjsmjO8ym579Vhsj6CJqTobVnr8aQvIVayjtHzLWG/dUpS+vSFqSBCCQs4OZXV7zo1Rm KfhQ== X-Gm-Message-State: ALoCoQlYMhnlXN8ud6B9WJSJE9mgDhpwTkdt84A+DpZaH19YYDPeBJVlj6uxdVYTjynpAujBb4t1 X-Received: by 10.180.108.144 with SMTP id hk16mr9219368wib.68.1415984627941; Fri, 14 Nov 2014 09:03:47 -0800 (PST) Received: from glumotte.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id cu9sm40352554wjb.0.2014.11.14.09.03.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Nov 2014 09:03:47 -0800 (PST) From: Olivier Matz To: dev@dpdk.org Date: Fri, 14 Nov 2014 18:03:17 +0100 Message-Id: <1415984609-2484-2-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1415984609-2484-1-git-send-email-olivier.matz@6wind.com> References: <1415635166-1364-1-git-send-email-olivier.matz@6wind.com> <1415984609-2484-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: jigsaw@gmail.com Subject: [dpdk-dev] [PATCH v2 01/13] igb/ixgbe: fix IP checksum calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Nov 2014 16:53:44 -0000 X-List-Received-Date: Fri, 14 Nov 2014 16:53:44 -0000 According to Intel® 82599 10 GbE Controller Datasheet (Table 7-38), both L2 and L3 lengths are needed to offload the IP checksum. Note that the e1000 driver does not need to be patched as it already contains the fix. Signed-off-by: Olivier Matz Acked-by: Konstantin Ananyev --- lib/librte_pmd_e1000/igb_rxtx.c | 2 +- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c index 0dca7b7..b406397 100644 --- a/lib/librte_pmd_e1000/igb_rxtx.c +++ b/lib/librte_pmd_e1000/igb_rxtx.c @@ -262,7 +262,7 @@ igbe_set_xmit_ctx(struct igb_tx_queue* txq, if (ol_flags & PKT_TX_IP_CKSUM) { type_tucmd_mlhl = E1000_ADVTXD_TUCMD_IPV4; - cmp_mask |= TX_MAC_LEN_CMP_MASK; + cmp_mask |= TX_MACIP_LEN_CMP_MASK; } /* Specify which HW CTX to upload. */ diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index f9b3fe3..ecebbf6 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c @@ -374,7 +374,7 @@ ixgbe_set_xmit_ctx(struct igb_tx_queue* txq, if (ol_flags & PKT_TX_IP_CKSUM) { type_tucmd_mlhl = IXGBE_ADVTXD_TUCMD_IPV4; - cmp_mask |= TX_MAC_LEN_CMP_MASK; + cmp_mask |= TX_MACIP_LEN_CMP_MASK; } /* Specify which HW CTX to upload. */ -- 2.1.0