From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id F22347F0C for ; Thu, 20 Nov 2014 23:48:31 +0100 (CET) Received: by mail-wg0-f43.google.com with SMTP id l18so5087936wgh.16 for ; Thu, 20 Nov 2014 14:59:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=Bh8v7KE+mwfoawNaynDX4M8MWOqUMV8kvh52HjLeteM=; b=KzmbVbpZ54xwLyOumQRu7L8L+oL6O7twPKjumdwg9p5vQLzjwnKHIir50aToo3Iumv 3+08Z5frD5ZU9zXDnudNS52yxM6tTCLTWjI5N532ishzoJjA9t1IvZJ0CU1L+kUu6AjU sWK6i0igkOJbM+YNNhjIVGrq/Djag5zoNJ8hGTmCQ+v4k8ei7Ql9x5hWFbk5m3v+hYWi 9/nqGv+EQf0Qlq0Lb7Kxi66XQX5ory9+lMy2GqryY4Q0myZ3TEUnTufaxkOaOZSZTNR2 mp2lGJtnPP9LfOHhUpQTTub52crtsHkLdBOM8PzGB8ijJYO6xTJfrlkzZsKq339Uc42N h7Ww== X-Gm-Message-State: ALoCoQnYXwHXdS/XlHCpsVuUUNDe4xIOABPu+IvgqMnMjq+HUO/qfAD6CSfKTWKnztmbYITH8nHf X-Received: by 10.194.120.164 with SMTP id ld4mr1244066wjb.67.1416524343843; Thu, 20 Nov 2014 14:59:03 -0800 (PST) Received: from glumotte.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id cz3sm5380581wjb.23.2014.11.20.14.59.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Nov 2014 14:59:03 -0800 (PST) From: Olivier Matz To: dev@dpdk.org Date: Thu, 20 Nov 2014 23:58:43 +0100 Message-Id: <1416524335-22753-2-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1416524335-22753-1-git-send-email-olivier.matz@6wind.com> References: <1415984609-2484-1-git-send-email-olivier.matz@6wind.com> <1416524335-22753-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: jigsaw@gmail.com Subject: [dpdk-dev] [PATCH v3 01/13] igb/ixgbe: fix IP checksum calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Nov 2014 22:48:32 -0000 According to Intel® 82599 10 GbE Controller Datasheet (Table 7-38), both L2 and L3 lengths are needed to offload the IP checksum. Note that the e1000 driver does not need to be patched as it already contains the fix. Signed-off-by: Olivier Matz Acked-by: Konstantin Ananyev --- lib/librte_pmd_e1000/igb_rxtx.c | 2 +- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c index 0dca7b7..b406397 100644 --- a/lib/librte_pmd_e1000/igb_rxtx.c +++ b/lib/librte_pmd_e1000/igb_rxtx.c @@ -262,7 +262,7 @@ igbe_set_xmit_ctx(struct igb_tx_queue* txq, if (ol_flags & PKT_TX_IP_CKSUM) { type_tucmd_mlhl = E1000_ADVTXD_TUCMD_IPV4; - cmp_mask |= TX_MAC_LEN_CMP_MASK; + cmp_mask |= TX_MACIP_LEN_CMP_MASK; } /* Specify which HW CTX to upload. */ diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index f9b3fe3..ecebbf6 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c @@ -374,7 +374,7 @@ ixgbe_set_xmit_ctx(struct igb_tx_queue* txq, if (ol_flags & PKT_TX_IP_CKSUM) { type_tucmd_mlhl = IXGBE_ADVTXD_TUCMD_IPV4; - cmp_mask |= TX_MAC_LEN_CMP_MASK; + cmp_mask |= TX_MACIP_LEN_CMP_MASK; } /* Specify which HW CTX to upload. */ -- 2.1.0