From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville
Date: Wed, 15 Oct 2014 14:21:55 +0200 [thread overview]
Message-ID: <1416793.NVMu20orOd@xps13> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A79C5EF@SHSMSX104.ccr.corp.intel.com>
Helin,
As you are in charge of i40e, here are 2 tips to acknowledge patches:
1) title should take this format:
i40e: add Rx error statistics
> Acked-by: Helin Zhang <helin.zhang@intel.com>
2) This line should be added right after the Signed-off-by.
And the rest of the email (patch body) can be removed.
This way, your answer would be faster to read.
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> > Sent: Wednesday, October 15, 2014 11:15 AM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville
This header is not needed also.
> > This patch adds incoming packet error statistics in the i40e_ethdev.c file.
> >
> > Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
[I remove the rest of the original email because I have no comment on it]
Thanks
--
Thomas
next prev parent reply other threads:[~2014-10-15 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 3:14 Jijiang Liu
2014-10-15 6:54 ` Zhang, Helin
2014-10-15 12:21 ` Thomas Monjalon [this message]
2014-10-16 0:55 ` Zhang, Helin
2014-10-15 12:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416793.NVMu20orOd@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).