[dpdk-dev] [PATCH v4 00/13] add TSO support

[Olivier Matz <olivier.matz@6wind.com>]

This series add TSO support in ixgbe DPDK driver. This is a rework
of the series sent earlier this week [1]. This work is based on
another version [2] that was posted several months ago and
which included a mbuf rework that is now in mainline.

Changes in v4:

- csum fwd engine: use PKT_TX_IPV4 and PKT_TX_IPV6 to tell the hardware
  the IP version of the packet as suggested by Konstantin.
- document these 2 flags, explaining they should be set for hw L4 cksum
  offload or TSO.
- rebase on latest head

Changes in v3:

- indicate that rte_get_rx_ol_flag_name() and rte_get_tx_ol_flag_name()
  should be kept synchronized with flags definition
- use sizeof() when appropriate in rte_raw_cksum()
- remove double semicolon in ixgbe driver
- reorder tx ol_flags as requested by Thomas
- add missing copyrights when big modifications are made
- enhance the help of tx_cksum command in testpmd
- enhance the description of csumonly (comments)

Changes in v2:

- move rte_get_rx_ol_flag_name() and rte_get_tx_ol_flag_name() in
  rte_mbuf.c, and fix comments
- use IGB_TX_OFFLOAD_MASK and IXGBE_TX_OFFLOAD_MASK to replace
  PKT_TX_OFFLOAD_MASK
- fix inner_l2_len and inner_l3_len bitfields: use uint64_t instead
  of uint16_t
- replace assignation of l2_len and l3_len by assignation of tx_offload.
  It now includes inner_l2_len and inner_l3_len at the same time.
- introduce a new cksum api in rte_ip.h following discussion with
  Konstantin
- reorder commits to have all TSO commits at the end of the series
- use ol_flags for phdr checksum calculation (this now matches ixgbe
  API: standard pseudo hdr cksum for TCP cksum offload, pseudo hdr
  cksum without ip paylen for TSO). This will probably be changed
  with a dev_prep_tx() like function for 2.0 release.
- rebase on latest head


This series first fixes some bugs that were discovered during the
development, adds some changes to the mbuf API (new l4_len and
tso_segsz fields), adds TSO support in ixgbe, reworks testpmd
csum forward engine, and finally adds TSO support in testpmd so it
can be validated.

The new fields added in mbuf try to be generic enough to apply to
other hardware in the future. To delegate the TCP segmentation to the
hardware, the user has to:

  - set the PKT_TX_TCP_SEG flag in mbuf->ol_flags (this flag implies
    PKT_TX_TCP_CKSUM)
  - set the flag PKT_TX_IPV4 or PKT_TX_IPV6
  - if it's IPv4, set the PKT_TX_IP_CKSUM flag and write the IP checksum
    to 0 in the packet
  - fill the mbuf offload information: l2_len, l3_len, l4_len, tso_segsz

  - calculate the pseudo header checksum without taking ip_len in account,
    and set it in the TCP header, for instance by using
    rte_ipv4_phdr_cksum(ip_hdr, ol_flags)

The test report will be added as an answer to this cover letter and
could be linked in the concerned commits.

[1] http://dpdk.org/ml/archives/dev/2014-November/007953.html
[2] http://dpdk.org/ml/archives/dev/2014-May/002537.html

Olivier Matz (13):
  igb/ixgbe: fix IP checksum calculation
  ixgbe: fix remaining pkt_flags variable size to 64 bits
  mbuf: reorder tx ol_flags
  mbuf: add help about TX checksum flags
  mbuf: remove too specific PKT_TX_OFFLOAD_MASK definition
  mbuf: add functions to get the name of an ol_flag
  testpmd: fix use of offload flags in testpmd
  testpmd: rework csum forward engine
  mbuf: introduce new checksum API
  mbuf: generic support for TCP segmentation offload
  ixgbe: support TCP segmentation offload
  testpmd: support TSO in csum forward engine
  testpmd: add a verbose mode csum forward engine

 app/test-pmd/cmdline.c              | 248 +++++++++--
 app/test-pmd/config.c               |  17 +-
 app/test-pmd/csumonly.c             | 817 ++++++++++++++++--------------------
 app/test-pmd/macfwd.c               |   5 +-
 app/test-pmd/macswap.c              |   5 +-
 app/test-pmd/rxonly.c               |  36 +-
 app/test-pmd/testpmd.c              |   2 +-
 app/test-pmd/testpmd.h              |  24 +-
 app/test-pmd/txonly.c               |   9 +-
 examples/ipv4_multicast/main.c      |   2 +-
 lib/librte_mbuf/rte_mbuf.c          |  49 +++
 lib/librte_mbuf/rte_mbuf.h          | 108 +++--
 lib/librte_net/rte_ip.h             | 208 +++++++++
 lib/librte_pmd_e1000/igb_rxtx.c     |  21 +-
 lib/librte_pmd_ixgbe/ixgbe_ethdev.c |   3 +-
 lib/librte_pmd_ixgbe/ixgbe_rxtx.c   | 179 +++++---
 lib/librte_pmd_ixgbe/ixgbe_rxtx.h   |  19 +-
 17 files changed, 1103 insertions(+), 649 deletions(-)

-- 
2.1.0