From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
Date: Thu, 4 Dec 2014 17:50:05 +0800 [thread overview]
Message-ID: <1417686605-6778-1-git-send-email-jing.d.chen@intel.com> (raw)
From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
i40e uses an bitmap array to store those vlan tags that are set by
application. In function i40e_set_vlan_filter, it stores vlan tag
to wrong place. This change will fix it.
Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
---
lib/librte_pmd_i40e/i40e_ethdev.c | 11 ++++-------
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index 87e750a..cebc21d 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -4163,8 +4163,8 @@ i40e_find_vlan_filter(struct i40e_vsi *vsi,
{
uint32_t vid_idx, vid_bit;
- vid_idx = (uint32_t) ((vlan_id >> 5) & 0x7F);
- vid_bit = (uint32_t) (1 << (vlan_id & 0x1F));
+ vid_idx = (uint32_t)(vlan_id / I40E_UINT32_BIT_SIZE);
+ vid_bit = (uint32_t)(1 << (vlan_id % I40E_UINT32_BIT_SIZE));
if (vsi->vfta[vid_idx] & vid_bit)
return 1;
@@ -4178,14 +4178,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi,
{
uint32_t vid_idx, vid_bit;
-#define UINT32_BIT_MASK 0x1F
-#define VALID_VLAN_BIT_MASK 0xFFF
/* VFTA is 32-bits size array, each element contains 32 vlan bits, Find the
* element first, then find the bits it belongs to
*/
- vid_idx = (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >>
- sizeof(uint32_t));
- vid_bit = (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK));
+ vid_idx = (uint32_t)(vlan_id / I40E_UINT32_BIT_SIZE);
+ vid_bit = (uint32_t)(1 << (vlan_id % I40E_UINT32_BIT_SIZE));
if (on)
vsi->vfta[vid_idx] |= vid_bit;
--
1.7.7.6
next reply other threads:[~2014-12-04 9:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 9:50 Chen Jing D(Mark) [this message]
2014-12-04 10:18 ` Qiu, Michael
2014-12-04 10:25 ` Chen, Jing D
2014-12-04 10:25 ` Thomas Monjalon
2014-12-04 10:30 ` Chen, Jing D
2014-12-04 10:38 ` Thomas Monjalon
2014-12-04 14:29 ` Chen, Jing D
2014-12-04 15:32 ` Thomas Monjalon
2014-12-05 4:56 ` Xie, Huawei
2014-12-05 9:18 ` Thomas Monjalon
2014-12-05 8:38 ` Chen, Jing D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417686605-6778-1-git-send-email-jing.d.chen@intel.com \
--to=jing.d.chen@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).