From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-ft5.fr.colt.net (smtp-ft5.fr.colt.net [213.41.78.197]) by dpdk.org (Postfix) with ESMTP id 20F0C8043 for ; Thu, 4 Dec 2014 15:26:57 +0100 (CET) Received: from smtp-ex6.fr.colt.net (smtp-ex6.fr.colt.net [213.41.78.122]) by smtp-ft5.fr.colt.net (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id sB4EQvBj014869 for ; Thu, 4 Dec 2014 15:26:57 +0100 Received: from 33.106-14-84.ripe.coltfrance.com ([84.14.106.33] helo=proxy.6wind.com) by smtp-ex6.fr.colt.net with esmtp (Exim) (envelope-from ) id 1XwXMv-0001x5-2G for ; Thu, 04 Dec 2014 15:26:57 +0100 Received: from 6wind.com (unknown [10.16.0.122]) by proxy.6wind.com (Postfix) with SMTP id 2072B5A038; Thu, 4 Dec 2014 15:26:55 +0100 (CET) Received: by 6wind.com (sSMTP sendmail emulation); Thu, 04 Dec 2014 15:26:55 +0100 From: Jean-Mickael Guerin To: dev@dpdk.org Date: Thu, 4 Dec 2014 15:26:20 +0100 Message-Id: <1417703181-23093-2-git-send-email-jean-mickael.guerin@6wind.com> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1417703181-23093-1-git-send-email-jean-mickael.guerin@6wind.com> References: <1417703181-23093-1-git-send-email-jean-mickael.guerin@6wind.com> X-ACL-Warn: 1/1 recipients OK. Subject: [dpdk-dev] [PATCH 1/2] ixgbe: fix setup of mbuf initializer template X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2014 14:26:57 -0000 Add a compiler barrier to make sure all fields covered by the marker rearm_data are assigned before the read. Signed-off-by: Jean-Mickael Guerin Acked-by: David Marchand Fixes: 0ff3324da2 ("ixgbe: rework vector pmd following mbuf changes") --- lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c index 579bc46..c1b5a78 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c @@ -739,6 +739,9 @@ ixgbe_rxq_vec_setup(struct igb_rx_queue *rxq) mb_def.buf_len = rxq->mb_pool->elt_size - sizeof(struct rte_mbuf); mb_def.port = rxq->port_id; rte_mbuf_refcnt_set(&mb_def, 1); + + /* prevent compiler reordering: rearm_data covers previous fields */ + rte_compiler_barrier(); rxq->mbuf_initializer = *((uint64_t *)&mb_def.rearm_data); return 0; } -- 2.1.3