From: Helin Zhang <helin.zhang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 1/2] i40e: remove checking rxd flag which is not public
Date: Fri, 5 Dec 2014 09:46:27 +0800 [thread overview]
Message-ID: <1417743988-15604-2-git-send-email-helin.zhang@intel.com> (raw)
In-Reply-To: <1417743988-15604-1-git-send-email-helin.zhang@intel.com>
According to the latest datasheet, RX descriptor error flag of
'RECIPE' is not for public use, so its checks should be removed.
Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
lib/librte_pmd_i40e/i40e_rxtx.c | 6 ------
1 file changed, 6 deletions(-)
v2 changes:
* Removed error flag of 'ECIPE' processing only in i40e PMD. All other error
flags were added back.
diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c
index 63c872d..7ffe50e 100644
--- a/lib/librte_pmd_i40e/i40e_rxtx.c
+++ b/lib/librte_pmd_i40e/i40e_rxtx.c
@@ -126,12 +126,6 @@ i40e_rxd_error_to_pkt_flags(uint64_t qword)
flags |= PKT_RX_MAC_ERR;
return flags;
}
-
- /* If RECIPE bit set, all other status indications should be ignored */
- if (unlikely(error_bits & (1 << I40E_RX_DESC_ERROR_RECIPE_SHIFT))) {
- flags |= PKT_RX_RECIP_ERR;
- return flags;
- }
if (unlikely(error_bits & (1 << I40E_RX_DESC_ERROR_HBO_SHIFT)))
flags |= PKT_RX_HBUF_OVERFLOW;
if (unlikely(error_bits & (1 << I40E_RX_DESC_ERROR_IPE_SHIFT)))
--
1.9.3
next prev parent reply other threads:[~2014-12-05 1:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 6:07 [dpdk-dev] [PATCH] i40e: Use one bit flag for all hardware detected RX packet errors Helin Zhang
2014-11-26 10:49 ` Ananyev, Konstantin
2014-11-26 11:22 ` Olivier MATZ
2014-11-26 13:38 ` Ananyev, Konstantin
2014-11-26 14:12 ` Olivier MATZ
2014-11-28 8:07 ` Zhang, Helin
2014-11-28 8:47 ` Olivier MATZ
2014-12-01 1:57 ` Zhang, Helin
2014-12-01 9:58 ` Olivier MATZ
2014-12-02 7:25 ` Zhang, Helin
2014-12-05 1:46 ` [dpdk-dev] [PATCH v2 0/2] fix of enabling all newly added error flags Helin Zhang
2014-12-05 1:46 ` Helin Zhang [this message]
2014-12-05 1:46 ` [dpdk-dev] [PATCH v2 2/2] mbuf: assign valid bit values for some RX and TX flags Helin Zhang
2014-12-05 10:49 ` Ananyev, Konstantin
2014-12-06 0:42 ` Zhang, Helin
2014-12-06 1:07 ` Zhang, Helin
2014-12-08 10:55 ` Ananyev, Konstantin
2014-12-09 2:29 ` Zhang, Helin
2014-12-06 1:33 ` [dpdk-dev] [PATCH v3] mbuf: fix of enabling all newly added RX error flags Helin Zhang
2014-12-08 10:44 ` Ananyev, Konstantin
2014-12-09 2:23 ` Zhang, Helin
2014-12-08 10:50 ` Thomas Monjalon
2014-12-09 2:14 ` Zhang, Helin
2014-12-09 6:22 ` Thomas Monjalon
2014-12-10 8:55 ` [dpdk-dev] [PATCH v4] " Helin Zhang
2014-12-10 9:35 ` Thomas Monjalon
2014-12-10 13:50 ` Zhang, Helin
2014-12-10 15:26 ` Thomas Monjalon
2014-12-10 22:29 ` Zhang, Helin
2014-12-11 11:16 ` Olivier MATZ
2014-12-12 1:27 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417743988-15604-2-git-send-email-helin.zhang@intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).