From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 633183F9 for ; Tue, 16 Dec 2014 15:50:43 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 16 Dec 2014 06:39:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="429669341" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by FMSMGA003.fm.intel.com with ESMTP; 16 Dec 2014 06:28:42 -0800 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id sBGEdixu001619; Tue, 16 Dec 2014 14:39:45 GMT Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id sBGEdit9012191; Tue, 16 Dec 2014 14:39:44 GMT Received: (from bricha3@localhost) by sivswdev01.ir.intel.com with id sBGEdiGu012187; Tue, 16 Dec 2014 14:39:44 GMT From: Bruce Richardson To: dev@dpdk.org Date: Tue, 16 Dec 2014 14:39:44 +0000 Message-Id: <1418740784-12155-1-git-send-email-bruce.richardson@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <20141216140926.GD13806@hmsreliant.think-freely.org> References: <20141216140926.GD13806@hmsreliant.think-freely.org> Subject: [dpdk-dev] [PATCH v2] testpmd: limit port mask bits to RTE_MAX_ETHPORTS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Dec 2014 14:50:44 -0000 The port mask parsing in testpmd allowed up to 64 bits to be processed, even if RTE_MAX_ETHPORTS is set to a max of 32. Fix this by only processing up to min(RTE_MAX_ETHPORTS,64) bits of the mask. Signed-off-by: Bruce Richardson --- V2: changed to use RTE_MIN in comparison, instead of double "<". --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 69a83c2..97b6525 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1440,7 +1440,7 @@ set_fwd_ports_mask(uint64_t portmask) return; } nb_pt = 0; - for (i = 0; i < 64; i++) { + for (i = 0; i < (unsigned)RTE_MIN(64, RTE_MAX_ETHPORTS); i++) { if (! ((uint64_t)(1ULL << i) & portmask)) continue; portlist[nb_pt++] = i; -- 1.9.3