From: Declan Doherty <declan.doherty@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3 1/3] bond: add bounds check before assigning active slave count value
Date: Wed, 17 Dec 2014 11:46:57 +0000 [thread overview]
Message-ID: <1418816819-13517-2-git-send-email-declan.doherty@intel.com> (raw)
In-Reply-To: <1418816819-13517-1-git-send-email-declan.doherty@intel.com>
Signed-off-by: Declan Doherty <declan.doherty@intel.com>
---
lib/librte_pmd_bond/rte_eth_bond_api.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/librte_pmd_bond/rte_eth_bond_api.c b/lib/librte_pmd_bond/rte_eth_bond_api.c
index ef5ddf4..b124784 100644
--- a/lib/librte_pmd_bond/rte_eth_bond_api.c
+++ b/lib/librte_pmd_bond/rte_eth_bond_api.c
@@ -115,6 +115,9 @@ activate_slave(struct rte_eth_dev *eth_dev, uint8_t port_id)
if (internals->mode == BONDING_MODE_8023AD)
bond_mode_8023ad_activate_slave(eth_dev, port_id);
+ RTE_VERIFY(internals->active_slave_count <
+ (RTE_DIM(internals->active_slaves) - 1));
+
internals->active_slaves[internals->active_slave_count] = port_id;
internals->active_slave_count++;
}
@@ -144,6 +147,7 @@ deactivate_slave(struct rte_eth_dev *eth_dev, uint8_t port_id)
sizeof(internals->active_slaves[0]));
}
+ RTE_VERIFY(active_count < RTE_DIM(internals->active_slaves));
internals->active_slave_count = active_count;
if (eth_dev->data->dev_started && internals->mode == BONDING_MODE_8023AD)
--
1.7.12.2
next prev parent reply other threads:[~2014-12-17 11:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 17:39 [dpdk-dev] [PATCH] bond: static analysis issues fix Declan Doherty
2014-12-12 18:30 ` Wodkowski, PawelX
2014-12-15 17:13 ` [dpdk-dev] [PATCH v2] " Declan Doherty
2014-12-16 8:50 ` Wodkowski, PawelX
2014-12-16 17:31 ` Thomas Monjalon
2014-12-17 11:46 ` [dpdk-dev] [PATCH v3 0/3] " Declan Doherty
2014-12-17 11:46 ` Declan Doherty [this message]
2014-12-17 11:46 ` [dpdk-dev] [PATCH v3 2/3] bond: fix pci_id_table allocation check in rte_eth_bond_create Declan Doherty
2014-12-17 11:46 ` [dpdk-dev] [PATCH v3 3/3] bond: eth_dev parameter used before NULL check in mac_address_get/set Declan Doherty
2014-12-17 23:43 ` [dpdk-dev] [PATCH v3 0/3] bond: static analysis issues fix Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418816819-13517-2-git-send-email-declan.doherty@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).