From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/5] test-devargs: fix misplaced braces in strncmp call
Date: Wed, 17 Dec 2014 13:55:21 +0100 [thread overview]
Message-ID: <1418820925-20318-2-git-send-email-olivier.matz@6wind.com> (raw)
In-Reply-To: <1418820925-20318-1-git-send-email-olivier.matz@6wind.com>
One occurrence call to strncmp had the closing brace in the wrong
place. Changing this form:
if (strncmp(X, Y, sizeof(X) != 0))
which does a comparison of length 1, to
if (strncmp(X, Y, sizeof(X)) != 0)
which does the correct length comparison and then compares the result
to zero in the "if" part.
Seen with clang-3.5:
"error: size argument in 'strncmp' call is a comparison"
This patch is similar to 261386248 but it looks that one occurence
was forgotten.
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
app/test/test_devargs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_devargs.c b/app/test/test_devargs.c
index dcbdd09..3d9f7bc 100644
--- a/app/test/test_devargs.c
+++ b/app/test/test_devargs.c
@@ -105,7 +105,7 @@ test_devargs(void)
devargs->pci.addr.devid != 0 ||
devargs->pci.addr.function != 1)
goto fail;
- if (strncmp(devargs->args, "", sizeof(devargs->args) != 0))
+ if (strncmp(devargs->args, "", sizeof(devargs->args)) != 0)
goto fail;
free_devargs_list();
--
2.1.3
next prev parent reply other threads:[~2014-12-17 12:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 12:55 [dpdk-dev] [PATCH 0/5] fix compilation issues seen with clang-3.5 Olivier Matz
2014-12-17 12:55 ` Olivier Matz [this message]
2014-12-17 12:55 ` [dpdk-dev] [PATCH 2/5] examples/l3fwd: fix compilation with clang 3.5 Olivier Matz
2014-12-17 12:55 ` [dpdk-dev] [PATCH 3/5] examples/netmap: fix overflow in ioctl operation Olivier Matz
2014-12-17 12:55 ` [dpdk-dev] [PATCH 4/5] examples/vm_power_manager: move -lvirt in LDLIBS Olivier Matz
2014-12-17 12:55 ` [dpdk-dev] [PATCH 5/5] examples/vm_power_manager: fix initialization of cmdline token Olivier Matz
2014-12-17 14:08 ` [dpdk-dev] [PATCH 0/5] fix compilation issues seen with clang-3.5 Bruce Richardson
2014-12-17 14:24 ` Bruce Richardson
2014-12-19 18:00 ` Bruce Richardson
2014-12-17 23:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418820925-20318-2-git-send-email-olivier.matz@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).