From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/3] mk: fix link examples to combined library
Date: Wed, 17 Dec 2014 22:59:16 +0100 [thread overview]
Message-ID: <1418853558-2445-2-git-send-email-thomas.monjalon@6wind.com> (raw)
In-Reply-To: <1418853558-2445-1-git-send-email-thomas.monjalon@6wind.com>
RTE_LIBNAME was defined only if BUILDING_RTE_SDK.
So external applications like examples were trying to link with -l
without any library name.
This bug appeared after fixing link to combined library (removing
link to separate libraries).
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
mk/rte.vars.mk | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/mk/rte.vars.mk b/mk/rte.vars.mk
index 1e874ee..d5b36be 100644
--- a/mk/rte.vars.mk
+++ b/mk/rte.vars.mk
@@ -71,10 +71,11 @@ ifneq ($(BUILDING_RTE_SDK),)
ifeq ($(RTE_BUILD_COMBINE_LIBS),)
RTE_BUILD_COMBINE_LIBS := n
endif
- RTE_LIBNAME := $(CONFIG_RTE_LIBNAME:"%"=%)
- ifeq ($(RTE_LIBNAME),)
- RTE_LIBNAME := intel_dpdk
- endif
+endif
+
+RTE_LIBNAME := $(CONFIG_RTE_LIBNAME:"%"=%)
+ifeq ($(RTE_LIBNAME),)
+RTE_LIBNAME := intel_dpdk
endif
# RTE_TARGET is deducted from config when we are building the SDK.
--
2.1.3
next prev parent reply other threads:[~2014-12-17 21:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 15:35 [dpdk-dev] [PATCH] mk: link combined lib using CC Sergio Gonzalez Monroy
2014-10-28 11:45 ` De Lara Guarch, Pablo
2014-10-28 14:51 ` Sergio Gonzalez Monroy
2014-10-28 15:33 ` Thomas Monjalon
2014-10-28 15:39 ` Sergio Gonzalez Monroy
2014-10-28 15:48 ` [dpdk-dev] [PATCH v2] mk: link combined shared " Sergio Gonzalez Monroy
2014-10-28 16:09 ` De Lara Guarch, Pablo
2014-12-16 18:48 ` Thomas Monjalon
2014-12-16 23:42 ` Thomas Monjalon
2014-12-17 10:41 ` Gonzalez Monroy, Sergio
2014-12-17 14:01 ` Thomas Monjalon
2014-12-17 18:49 ` Thomas Monjalon
2014-12-17 21:59 ` [dpdk-dev] [PATCH 0/3] mk: fix link options Thomas Monjalon
2014-12-17 21:59 ` Thomas Monjalon [this message]
2014-12-17 21:59 ` [dpdk-dev] [PATCH 2/3] mk: forbid multiple definitions Thomas Monjalon
2014-12-17 21:59 ` [dpdk-dev] [PATCH 3/3] mk: fix link with CC Thomas Monjalon
2014-12-17 23:35 ` [dpdk-dev] [PATCH 0/3] mk: fix link options Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418853558-2445-2-git-send-email-thomas.monjalon@6wind.com \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).