DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v4 0/7] Move EAL common function
@ 2015-01-06 17:24 Ravi Kerur
  2015-03-30 21:29 ` Thomas Monjalon
  0 siblings, 1 reply; 7+ messages in thread
From: Ravi Kerur @ 2015-01-06 17:24 UTC (permalink / raw)
  To: dev; +Cc: rkerur

Fix v3 PATCH review comments from Thomas.
eal_common.c is further split into eal_common_system.c and
eal_common_runtime.c files with appropriate functions.
eal_externs.h file is removed and _get_ and _set_ APIs are
used to access variables.
Functions with same signature in Linux and BSD but different
names are kept intact but Linux function name is used as
wrapper for BSD.
Added eal_pci.c in v4 PATCH.
New files added follow _common_ naming conventions.
Tested against Ubuntu and FreeBSD.

Ravi Kerur (7):
  Move common functions in eal_debug.c
  Move common functions in eal_thread.c
  Move common functions in eal.c
  Move common functions in eal_lcore.c
  Move common functions in eal_timer.c
  Move common functions in eal_memory.c
  Move common functions in eal_pci.c

 app/test/test_debug.c                      |   1 -
 lib/librte_eal/bsdapp/eal/Makefile         |  12 +-
 lib/librte_eal/bsdapp/eal/eal.c            | 269 ++++----------------------
 lib/librte_eal/bsdapp/eal/eal_debug.c      | 113 -----------
 lib/librte_eal/bsdapp/eal/eal_lcore.c      |  61 ++----
 lib/librte_eal/bsdapp/eal/eal_memory.c     |  47 ++---
 lib/librte_eal/bsdapp/eal/eal_pci.c        | 127 +------------
 lib/librte_eal/bsdapp/eal/eal_thread.c     | 233 -----------------------
 lib/librte_eal/bsdapp/eal/eal_timer.c      |  54 +-----
 lib/librte_eal/common/eal_common_debug.c   | 106 +++++++++++
 lib/librte_eal/common/eal_common_lcore.c   |  95 ++++++++++
 lib/librte_eal/common/eal_common_memory.c  |  38 +++-
 lib/librte_eal/common/eal_common_pci.c     | 171 ++++++++++++++++-
 lib/librte_eal/common/eal_common_runtime.c | 201 ++++++++++++++++++++
 lib/librte_eal/common/eal_common_system.c  | 203 ++++++++++++++++++++
 lib/librte_eal/common/eal_common_thread.c  | 248 ++++++++++++++++++++++++
 lib/librte_eal/common/eal_common_timer.c   | 101 ++++++++++
 lib/librte_eal/common/eal_hugepages.h      |   1 +
 lib/librte_eal/common/eal_private.h        | 205 ++++++++++++++++++++
 lib/librte_eal/common/include/rte_debug.h  |   7 -
 lib/librte_eal/linuxapp/eal/Makefile       |  12 +-
 lib/librte_eal/linuxapp/eal/eal.c          | 290 +++++------------------------
 lib/librte_eal/linuxapp/eal/eal_debug.c    | 113 -----------
 lib/librte_eal/linuxapp/eal/eal_lcore.c    |  55 +-----
 lib/librte_eal/linuxapp/eal/eal_memory.c   |  36 +---
 lib/librte_eal/linuxapp/eal/eal_pci.c      | 113 +----------
 lib/librte_eal/linuxapp/eal/eal_pci_init.h |   6 -
 lib/librte_eal/linuxapp/eal/eal_pci_uio.c  |  36 +---
 lib/librte_eal/linuxapp/eal/eal_pci_vfio.c |   9 +-
 lib/librte_eal/linuxapp/eal/eal_thread.c   | 233 -----------------------
 lib/librte_eal/linuxapp/eal/eal_timer.c    |  55 +-----
 31 files changed, 1522 insertions(+), 1729 deletions(-)
 delete mode 100644 lib/librte_eal/bsdapp/eal/eal_debug.c
 delete mode 100644 lib/librte_eal/bsdapp/eal/eal_thread.c
 create mode 100644 lib/librte_eal/common/eal_common_debug.c
 create mode 100644 lib/librte_eal/common/eal_common_lcore.c
 create mode 100644 lib/librte_eal/common/eal_common_runtime.c
 create mode 100644 lib/librte_eal/common/eal_common_system.c
 create mode 100644 lib/librte_eal/common/eal_common_thread.c
 create mode 100644 lib/librte_eal/common/eal_common_timer.c
 delete mode 100644 lib/librte_eal/linuxapp/eal/eal_debug.c
 delete mode 100644 lib/librte_eal/linuxapp/eal/eal_thread.c

-- 
1.9.1

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v4 0/7] Move EAL common function
@ 2015-01-06 17:26 Ravi Kerur
  0 siblings, 0 replies; 7+ messages in thread
From: Ravi Kerur @ 2015-01-06 17:26 UTC (permalink / raw)
  To: dev

Fix v3 PATCH review comments from Thomas.
eal_common.c is further split into eal_common_system.c and
eal_common_runtime.c files with appropriate functions.
eal_externs.h file is removed and _get_ and _set_ APIs are
used to access variables.
Functions with same signature in Linux and BSD but different
names are kept intact but Linux function name is used as
wrapper for BSD.
Added eal_pci.c in v4 PATCH.
New files added follow _common_ naming conventions.
Tested against Ubuntu and FreeBSD.

Ravi Kerur (7):
  Move common functions in eal_debug.c
  Move common functions in eal_thread.c
  Move common functions in eal.c
  Move common functions in eal_lcore.c
  Move common functions in eal_timer.c
  Move common functions in eal_memory.c
  Move common functions in eal_pci.c

 app/test/test_debug.c                      |   1 -
 lib/librte_eal/bsdapp/eal/Makefile         |  12 +-
 lib/librte_eal/bsdapp/eal/eal.c            | 269 ++++----------------------
 lib/librte_eal/bsdapp/eal/eal_debug.c      | 113 -----------
 lib/librte_eal/bsdapp/eal/eal_lcore.c      |  61 ++----
 lib/librte_eal/bsdapp/eal/eal_memory.c     |  47 ++---
 lib/librte_eal/bsdapp/eal/eal_pci.c        | 127 +------------
 lib/librte_eal/bsdapp/eal/eal_thread.c     | 233 -----------------------
 lib/librte_eal/bsdapp/eal/eal_timer.c      |  54 +-----
 lib/librte_eal/common/eal_common_debug.c   | 106 +++++++++++
 lib/librte_eal/common/eal_common_lcore.c   |  95 ++++++++++
 lib/librte_eal/common/eal_common_memory.c  |  38 +++-
 lib/librte_eal/common/eal_common_pci.c     | 171 ++++++++++++++++-
 lib/librte_eal/common/eal_common_runtime.c | 201 ++++++++++++++++++++
 lib/librte_eal/common/eal_common_system.c  | 203 ++++++++++++++++++++
 lib/librte_eal/common/eal_common_thread.c  | 248 ++++++++++++++++++++++++
 lib/librte_eal/common/eal_common_timer.c   | 101 ++++++++++
 lib/librte_eal/common/eal_hugepages.h      |   1 +
 lib/librte_eal/common/eal_private.h        | 205 ++++++++++++++++++++
 lib/librte_eal/common/include/rte_debug.h  |   7 -
 lib/librte_eal/linuxapp/eal/Makefile       |  12 +-
 lib/librte_eal/linuxapp/eal/eal.c          | 290 +++++------------------------
 lib/librte_eal/linuxapp/eal/eal_debug.c    | 113 -----------
 lib/librte_eal/linuxapp/eal/eal_lcore.c    |  55 +-----
 lib/librte_eal/linuxapp/eal/eal_memory.c   |  36 +---
 lib/librte_eal/linuxapp/eal/eal_pci.c      | 113 +----------
 lib/librte_eal/linuxapp/eal/eal_pci_init.h |   6 -
 lib/librte_eal/linuxapp/eal/eal_pci_uio.c  |  36 +---
 lib/librte_eal/linuxapp/eal/eal_pci_vfio.c |   9 +-
 lib/librte_eal/linuxapp/eal/eal_thread.c   | 233 -----------------------
 lib/librte_eal/linuxapp/eal/eal_timer.c    |  55 +-----
 31 files changed, 1522 insertions(+), 1729 deletions(-)
 delete mode 100644 lib/librte_eal/bsdapp/eal/eal_debug.c
 delete mode 100644 lib/librte_eal/bsdapp/eal/eal_thread.c
 create mode 100644 lib/librte_eal/common/eal_common_debug.c
 create mode 100644 lib/librte_eal/common/eal_common_lcore.c
 create mode 100644 lib/librte_eal/common/eal_common_runtime.c
 create mode 100644 lib/librte_eal/common/eal_common_system.c
 create mode 100644 lib/librte_eal/common/eal_common_thread.c
 create mode 100644 lib/librte_eal/common/eal_common_timer.c
 delete mode 100644 lib/librte_eal/linuxapp/eal/eal_debug.c
 delete mode 100644 lib/librte_eal/linuxapp/eal/eal_thread.c

-- 
1.9.1

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-04-09 19:45 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-06 17:24 [dpdk-dev] [PATCH v4 0/7] Move EAL common function Ravi Kerur
2015-03-30 21:29 ` Thomas Monjalon
2015-03-30 23:15   ` Ravi Kerur
2015-03-30 23:24     ` Thomas Monjalon
2015-03-31 18:39       ` Ravi Kerur
2015-04-09 19:45         ` Ravi Kerur
2015-01-06 17:26 Ravi Kerur

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).