From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C3AFA5A70 for ; Tue, 20 Jan 2015 19:41:22 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 20 Jan 2015 10:41:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,435,1418112000"; d="scan'208";a="672969138" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga002.jf.intel.com with ESMTP; 20 Jan 2015 10:41:20 -0800 Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com [10.237.217.46]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t0KIfJcL029473; Tue, 20 Jan 2015 18:41:19 GMT Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1]) by sivswdev02.ir.intel.com with ESMTP id t0KIfJQJ018784; Tue, 20 Jan 2015 18:41:19 GMT Received: (from kananye1@localhost) by sivswdev02.ir.intel.com with id t0KIfJLG018780; Tue, 20 Jan 2015 18:41:19 GMT From: Konstantin Ananyev To: dev@dpdk.org Date: Tue, 20 Jan 2015 18:40:49 +0000 Message-Id: <1421779267-18492-1-git-send-email-konstantin.ananyev@intel.com> X-Mailer: git-send-email 1.7.4.1 Subject: [dpdk-dev] [PATCH v3 00/18] ACL: New AVX2 classify method and several other enhancements. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2015 18:41:23 -0000 v3 changes: Applied review comments from Thomas: - fix spelling errors reported by codespell. - split last patch into two: first to remove unused macros, second to add some comments about ACL internal layout. v2 changes: - When build with the compilers that don't support AVX2 instructions, make rte_acl_classify_avx2() do nothing and return an error. - Remove unneeded 'ifdef __AVX2__' in acl_run_avx2.*. - Reorder order of patches in the set, to keep RTE_LIBRTE_ACL_STANDALONE=y always buildable. This patch series contain several fixes and enhancements for ACL library. See complete list below. Two main changes that are externally visible: - Introduce new classify method: RTE_ACL_CLASSIFY_AVX2. It uses AVX2 instructions and 256 bit wide data types to perform internal trie traversal. That helps to increase classify() throughput. This method is selected as default one on CPUs that supports AVX2. - Introduce new field in the build config structure: max_size. It specifies maximum size that internal RT structure for given context can reach. The purpose of that is to allow user to decide about space/performance trade-off (faster classify() vs less space for RT internal structures) for each given set of rules. Konstantin Ananyev (18): fix fix compilation issues with RTE_LIBRTE_ACL_STANDALONE=y app/test: few small fixes fot test_acl.c librte_acl: make data_indexes long enough to survive idle transitions. librte_acl: remove build phase heuristsic with negative performance effect. librte_acl: fix a bug at build phase that can cause matches beeing overwirtten. librte_acl: introduce DFA nodes compression (group64) for identical entries. librte_acl: build/gen phase - simplify the way match nodes are allocated. librte_acl: make scalar RT code to be more similar to vector one. librte_acl: a bit of RT code deduplication. EAL: introduce rte_ymm and relatives in rte_common_vect.h. librte_acl: add AVX2 as new rte_acl_classify() method test-acl: add ability to manually select RT method. librte_acl: Remove search_sse_2 and relatives. libter_acl: move lo/hi dwords shuffle out from calc_addr libte_acl: make calc_addr a define to deduplicate the code. libte_acl: introduce max_size into rte_acl_config. libte_acl: remove unused macros. libte_acl: add some comments about ACL internal layout. app/test-acl/main.c | 126 +++-- app/test/test_acl.c | 8 +- examples/l3fwd-acl/main.c | 3 +- examples/l3fwd/main.c | 2 +- lib/librte_acl/Makefile | 18 + lib/librte_acl/acl.h | 58 ++- lib/librte_acl/acl_bld.c | 392 +++++++--------- lib/librte_acl/acl_gen.c | 268 +++++++---- lib/librte_acl/acl_run.h | 7 +- lib/librte_acl/acl_run_avx2.c | 54 +++ lib/librte_acl/acl_run_avx2.h | 284 ++++++++++++ lib/librte_acl/acl_run_scalar.c | 65 ++- lib/librte_acl/acl_run_sse.c | 585 +----------------------- lib/librte_acl/acl_run_sse.h | 357 +++++++++++++++ lib/librte_acl/acl_vect.h | 132 +++--- lib/librte_acl/rte_acl.c | 47 +- lib/librte_acl/rte_acl.h | 4 + lib/librte_acl/rte_acl_osdep_alone.h | 47 +- lib/librte_eal/common/include/rte_common_vect.h | 39 +- lib/librte_lpm/rte_lpm.h | 2 +- 20 files changed, 1444 insertions(+), 1054 deletions(-) create mode 100644 lib/librte_acl/acl_run_avx2.c create mode 100644 lib/librte_acl/acl_run_avx2.h create mode 100644 lib/librte_acl/acl_run_sse.h -- 1.8.5.3