DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] pcap: Fix ethernet device's name for pcap port
@ 2015-01-20 19:15 Remi Pommarel
  2015-01-27 11:46 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Remi Pommarel @ 2015-01-20 19:15 UTC (permalink / raw)
  To: dev

Ethernet device's data should contain the virtual device name for pcap port.
This name is correctly set by rte_eth_dev_allocate() at initialization time,
but it is directly lost.

Signed-off-by: Remi Pommarel <repk@triplefau.lt>
---
 lib/librte_pmd_pcap/rte_eth_pcap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c b/lib/librte_pmd_pcap/rte_eth_pcap.c
index f12d1e7..aa01464 100644
--- a/lib/librte_pmd_pcap/rte_eth_pcap.c
+++ b/lib/librte_pmd_pcap/rte_eth_pcap.c
@@ -735,6 +735,7 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,
 
 	data->dev_private = *internals;
 	data->port_id = (*eth_dev)->data->port_id;
+	snprintf(data->name, sizeof(data->name), "%s", (*eth_dev)->data->name);
 	data->nb_rx_queues = (uint16_t)nb_rx_queues;
 	data->nb_tx_queues = (uint16_t)nb_tx_queues;
 	data->dev_link = pmd_link;
-- 
2.0.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] pcap: Fix ethernet device's name for pcap port
  2015-01-20 19:15 [dpdk-dev] [PATCH] pcap: Fix ethernet device's name for pcap port Remi Pommarel
@ 2015-01-27 11:46 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2015-01-27 11:46 UTC (permalink / raw)
  To: Remi Pommarel; +Cc: dev

> Ethernet device's data should contain the virtual device name for pcap port.
> This name is correctly set by rte_eth_dev_allocate() at initialization time,
> but it is directly lost.
> 
> Signed-off-by: Remi Pommarel <repk@triplefau.lt>

Fixes: 83b41136934d ("ethdev: add unique name to devices")
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-27 11:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-20 19:15 [dpdk-dev] [PATCH] pcap: Fix ethernet device's name for pcap port Remi Pommarel
2015-01-27 11:46 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).