DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ouyang Changchun <changchun.ouyang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss
Date: Wed, 21 Jan 2015 11:38:43 +0800	[thread overview]
Message-ID: <1421811523-18737-1-git-send-email-changchun.ouyang@intel.com> (raw)

To follow up the comments from Wodkowski, PawelX, remove this unnecessary check,
as check_mq_mode has already check the queue number in device configure stage,
if the queue number of vf is not correct, it will return error code and exit,
so it doesn't need check again here in device start stage(note: pf_host_configure
is called in device start stage).

This fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f

Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
---
 lib/librte_pmd_ixgbe/ixgbe_pf.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c
index 93f6e43..dbda9b5 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
@@ -187,21 +187,6 @@ int ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev)
 	IXGBE_WRITE_REG(hw, IXGBE_MPSAR_LO(hw->mac.num_rar_entries), 0);
 	IXGBE_WRITE_REG(hw, IXGBE_MPSAR_HI(hw->mac.num_rar_entries), 0);
 
-	/*
-	 * VF RSS can support at most 4 queues for each VF, even if
-	 * 8 queues are available for each VF, it need refine to 4
-	 * queues here due to this limitation, otherwise no queue
-	 * will receive any packet even RSS is enabled.
-	 */
-	if (eth_dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_VMDQ_RSS) {
-		if (RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool == 8) {
-			RTE_ETH_DEV_SRIOV(eth_dev).active = ETH_32_POOLS;
-			RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool = 4;
-			RTE_ETH_DEV_SRIOV(eth_dev).def_pool_q_idx =
-				dev_num_vf(eth_dev) * 4;
-		}
-	}
-
 	/* set VMDq map to default PF pool */
 	hw->mac.ops.set_vmdq(hw, 0, RTE_ETH_DEV_SRIOV(eth_dev).def_vmdq_idx);
 
-- 
1.8.4.2

             reply	other threads:[~2015-01-21  3:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21  3:38 Ouyang Changchun [this message]
2015-01-27 12:12 ` Thomas Monjalon
2015-01-28  1:35   ` Ouyang, Changchun
2015-01-29 16:13     ` Wodkowski, PawelX
2015-01-30  1:20       ` Ouyang, Changchun
2015-01-30 10:16         ` Wodkowski, PawelX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421811523-18737-1-git-send-email-changchun.ouyang@intel.com \
    --to=changchun.ouyang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).