From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 69D535A15 for ; Wed, 21 Jan 2015 04:38:51 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 20 Jan 2015 19:38:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,439,1418112000"; d="scan'208";a="665007039" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by fmsmga002.fm.intel.com with ESMTP; 20 Jan 2015 19:38:49 -0800 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shvmail01.sh.intel.com with ESMTP id t0L3cl9e011860; Wed, 21 Jan 2015 11:38:47 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id t0L3cjq9018918; Wed, 21 Jan 2015 11:38:47 +0800 Received: (from couyang@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t0L3cj3O018914; Wed, 21 Jan 2015 11:38:45 +0800 From: Ouyang Changchun To: dev@dpdk.org Date: Wed, 21 Jan 2015 11:38:43 +0800 Message-Id: <1421811523-18737-1-git-send-email-changchun.ouyang@intel.com> X-Mailer: git-send-email 1.7.12.2 Subject: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2015 03:38:51 -0000 To follow up the comments from Wodkowski, PawelX, remove this unnecessary check, as check_mq_mode has already check the queue number in device configure stage, if the queue number of vf is not correct, it will return error code and exit, so it doesn't need check again here in device start stage(note: pf_host_configure is called in device start stage). This fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f Signed-off-by: Changchun Ouyang --- lib/librte_pmd_ixgbe/ixgbe_pf.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c index 93f6e43..dbda9b5 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c @@ -187,21 +187,6 @@ int ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev) IXGBE_WRITE_REG(hw, IXGBE_MPSAR_LO(hw->mac.num_rar_entries), 0); IXGBE_WRITE_REG(hw, IXGBE_MPSAR_HI(hw->mac.num_rar_entries), 0); - /* - * VF RSS can support at most 4 queues for each VF, even if - * 8 queues are available for each VF, it need refine to 4 - * queues here due to this limitation, otherwise no queue - * will receive any packet even RSS is enabled. - */ - if (eth_dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_VMDQ_RSS) { - if (RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool == 8) { - RTE_ETH_DEV_SRIOV(eth_dev).active = ETH_32_POOLS; - RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool = 4; - RTE_ETH_DEV_SRIOV(eth_dev).def_pool_q_idx = - dev_num_vf(eth_dev) * 4; - } - } - /* set VMDq map to default PF pool */ hw->mac.ops.set_vmdq(hw, 0, RTE_ETH_DEV_SRIOV(eth_dev).def_vmdq_idx); -- 1.8.4.2