DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] enic: silence log message
@ 2015-02-08 17:36 Stephen Hemminger
  2015-02-08 17:36 ` Stephen Hemminger
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2015-02-08 17:36 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger

From: Stephen Hemminger <shemming@brocade.com>

Silence is normal. drivers should speak only when spoken to and not
be chatty.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_pmd_enic/enic_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c
index 48fdca2..dad8922 100644
--- a/lib/librte_pmd_enic/enic_main.c
+++ b/lib/librte_pmd_enic/enic_main.c
@@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic)
 	struct rte_pci_device *pdev = enic->pdev;
 	int err = -1;
 
-	dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION);
-
 	enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
 	enic->bar0.len = pdev->mem_resource[0].len;
 
-- 
2.1.4

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-dev] [PATCH] enic: silence log message
  2015-02-08 17:36 [dpdk-dev] [PATCH] enic: silence log message Stephen Hemminger
@ 2015-02-08 17:36 ` Stephen Hemminger
  2015-02-09 12:21   ` David Marchand
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2015-02-08 17:36 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger

From: Stephen Hemminger <shemming@brocade.com>

Silence is normal. drivers should speak only when spoken to and not
be chatty.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_pmd_enic/enic_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c
index 48fdca2..dad8922 100644
--- a/lib/librte_pmd_enic/enic_main.c
+++ b/lib/librte_pmd_enic/enic_main.c
@@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic)
 	struct rte_pci_device *pdev = enic->pdev;
 	int err = -1;
 
-	dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION);
-
 	enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
 	enic->bar0.len = pdev->mem_resource[0].len;
 
-- 
2.1.4

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] enic: silence log message
  2015-02-08 17:36 ` Stephen Hemminger
@ 2015-02-09 12:21   ` David Marchand
  2015-02-09 16:11     ` Stephen Hemminger
  0 siblings, 1 reply; 7+ messages in thread
From: David Marchand @ 2015-02-09 12:21 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Stephen Hemminger

On Sun, Feb 8, 2015 at 6:36 PM, Stephen Hemminger <
stephen@networkplumber.org> wrote:

> From: Stephen Hemminger <shemming@brocade.com>
>
> Silence is normal. drivers should speak only when spoken to and not
> be chatty.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/librte_pmd_enic/enic_main.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/lib/librte_pmd_enic/enic_main.c
> b/lib/librte_pmd_enic/enic_main.c
> index 48fdca2..dad8922 100644
> --- a/lib/librte_pmd_enic/enic_main.c
> +++ b/lib/librte_pmd_enic/enic_main.c
> @@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic)
>         struct rte_pci_device *pdev = enic->pdev;
>         int err = -1;
>
> -       dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION);
> -
>         enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
>         enic->bar0.len = pdev->mem_resource[0].len;
>

NAK.

The main problem is that enic pmd is using printf to write logs.
So the pmd should be fixed so that dev_* macros use RTE_LOG.

Silence is good when it is the default behaviour.
But I prefer we can change this at runtime, rather than strip the log
messages, especially for init.


-- 
David Marchand

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] enic: silence log message
  2015-02-09 12:21   ` David Marchand
@ 2015-02-09 16:11     ` Stephen Hemminger
  2015-02-15  6:13       ` Sujith Sankar (ssujith)
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2015-02-09 16:11 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Stephen Hemminger

Agree it should not use printf.
If you insist on keeping the useless message then it should be log level
debug

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] enic: silence log message
  2015-02-09 16:11     ` Stephen Hemminger
@ 2015-02-15  6:13       ` Sujith Sankar (ssujith)
  2015-02-15  6:29         ` Sujith Sankar (ssujith)
  0 siblings, 1 reply; 7+ messages in thread
From: Sujith Sankar (ssujith) @ 2015-02-15  6:13 UTC (permalink / raw)
  To: Stephen Hemminger, David Marchand; +Cc: dev

Hi Stephen, David,

I agree with you and shall submit this change.

Thanks,
-Sujith

On 09/02/15 9:41 pm, "Stephen Hemminger" <stephen@networkplumber.org>
wrote:

>Agree it should not use printf.
>If you insist on keeping the useless message then it should be log level
>debug

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] enic: silence log message
  2015-02-15  6:13       ` Sujith Sankar (ssujith)
@ 2015-02-15  6:29         ` Sujith Sankar (ssujith)
  0 siblings, 0 replies; 7+ messages in thread
From: Sujith Sankar (ssujith) @ 2015-02-15  6:29 UTC (permalink / raw)
  To: Stephen Hemminger, David Marchand; +Cc: dev

Stephen,
Saw your patch. Will take a look.

Thanks,
-Sujith

On 15/02/15 11:43 am, "Sujith Sankar (ssujith)" <ssujith@cisco.com> wrote:

>Hi Stephen, David,
>
>I agree with you and shall submit this change.
>
>Thanks,
>-Sujith
>
>On 09/02/15 9:41 pm, "Stephen Hemminger" <stephen@networkplumber.org>
>wrote:
>
>>Agree it should not use printf.
>>If you insist on keeping the useless message then it should be log level
>>debug
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-dev] [PATCH] enic: silence log message
@ 2015-02-08 17:35 Stephen Hemminger
  0 siblings, 0 replies; 7+ messages in thread
From: Stephen Hemminger @ 2015-02-08 17:35 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger

From: Stephen Hemminger <shemming@brocade.com>

Silence is normal. drivers should speak only when spoken to and not
be chatty.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_pmd_enic/enic_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c
index 48fdca2..dad8922 100644
--- a/lib/librte_pmd_enic/enic_main.c
+++ b/lib/librte_pmd_enic/enic_main.c
@@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic)
 	struct rte_pci_device *pdev = enic->pdev;
 	int err = -1;
 
-	dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION);
-
 	enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
 	enic->bar0.len = pdev->mem_resource[0].len;
 
-- 
2.1.4

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-02-15  6:29 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-08 17:36 [dpdk-dev] [PATCH] enic: silence log message Stephen Hemminger
2015-02-08 17:36 ` Stephen Hemminger
2015-02-09 12:21   ` David Marchand
2015-02-09 16:11     ` Stephen Hemminger
2015-02-15  6:13       ` Sujith Sankar (ssujith)
2015-02-15  6:29         ` Sujith Sankar (ssujith)
  -- strict thread matches above, loose matches on Subject: below --
2015-02-08 17:35 Stephen Hemminger

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git