[dpdk-dev] [PATCH] eal_pci: Fix max_vfs missing for none igb_uio driver

[dpdk-dev] [PATCH] eal_pci: Fix max_vfs missing for none igb_uio driver

[Michael Qiu]

max_vfs will only be created by igb_uio driver, for other
drivers like vfio or pci_uio_generic, max_vfs will miss.

But sriov_numvfs is not driver related, just get the vf numbers
from that field.

Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
 lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
index 1f43688..3da4b69 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -305,7 +305,7 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,
 
 	/* get max_vfs */
 	dev->max_vfs = 0;
-	snprintf(filename, sizeof(filename), "%s/max_vfs", dirname);
+	snprintf(filename, sizeof(filename), "%s/sriov_numvfs", dirname);
 	if (!access(filename, F_OK) &&
 	    eal_parse_sysfs_value(filename, &tmp) == 0) {
 		dev->max_vfs = (uint16_t)tmp;
-- 
1.9.3

Re: [dpdk-dev] [PATCH] eal_pci: Fix max_vfs missing for none igb_uio driver

[David Marchand]

Hello Michael,

On Wed, Feb 11, 2015 at 12:10 PM, Michael Qiu <michael.qiu@intel.com> wrote:

> max_vfs will only be created by igb_uio driver, for other
> drivers like vfio or pci_uio_generic, max_vfs will miss.
>
> But sriov_numvfs is not driver related, just get the vf numbers
> from that field.
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
>  lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c
> b/lib/librte_eal/linuxapp/eal/eal_pci.c
> index 1f43688..3da4b69 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
> @@ -305,7 +305,7 @@ pci_scan_one(const char *dirname, uint16_t domain,
> uint8_t bus,
>
>         /* get max_vfs */
>         dev->max_vfs = 0;
> -       snprintf(filename, sizeof(filename), "%s/max_vfs", dirname);
> +       snprintf(filename, sizeof(filename), "%s/sriov_numvfs", dirname);
>         if (!access(filename, F_OK) &&
>             eal_parse_sysfs_value(filename, &tmp) == 0) {
>                 dev->max_vfs = (uint16_t)tmp;
>
>
Not too sure about this change.
Quickly looked, and as far as I can see, sriov_numvfs has been introduced
by 1789382a ("PCI: SRIOV control and status via sysfs").

Won't your change break anything that uses a kernel < 3.8 (not backported) ?


-- 
David Marchand

Re: [dpdk-dev] [PATCH] eal_pci: Fix max_vfs missing for none igb_uio driver

[Qiu, Michael]

On 2/11/2015 8:32 PM, David Marchand wrote:
> Hello Michael, 
>
> On Wed, Feb 11, 2015 at 12:10 PM, Michael Qiu <michael.qiu@intel.com
> <mailto:michael.qiu@intel.com>> wrote:
>
>     max_vfs will only be created by igb_uio driver, for other
>     drivers like vfio or pci_uio_generic, max_vfs will miss.
>
>     But sriov_numvfs is not driver related, just get the vf numbers
>     from that field.
>
>     Signed-off-by: Michael Qiu <michael.qiu@intel.com
>     <mailto:michael.qiu@intel.com>>
>     ---
>      lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
>
>     diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c
>     b/lib/librte_eal/linuxapp/eal/eal_pci.c
>     index 1f43688..3da4b69 100644
>     --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
>     +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
>     @@ -305,7 +305,7 @@ pci_scan_one(const char *dirname, uint16_t
>     domain, uint8_t bus,
>
>             /* get max_vfs */
>             dev->max_vfs = 0;
>     -       snprintf(filename, sizeof(filename), "%s/max_vfs", dirname);
>     +       snprintf(filename, sizeof(filename), "%s/sriov_numvfs",
>     dirname);
>             if (!access(filename, F_OK) &&
>                 eal_parse_sysfs_value(filename, &tmp) == 0) {
>                     dev->max_vfs = (uint16_t)tmp;
>
>
> Not too sure about this change.
> Quickly looked, and as far as I can see, sriov_numvfs has been
> introduced by 1789382a ("PCI: SRIOV control and status via sysfs").
>
> Won't your change break anything that uses a kernel < 3.8 (not
> backported) ?

OK, you are right, I will fix this in v2, actually it will break nothing
as the code already done accessing check.

But not enough, for kernel version less than 3.8 and driver is igb_uio,
it is indeed not suitable for leaving max_vfs zero.

BTW, for kernel version less than 3.8 and driver is vfio or
pci_uio_generic, how could we fill this field?

Thanks,
Michael
>
>
> -- 
> David Marchand

[dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver

[Michael Qiu]

max_vfs will only be created by igb_uio driver, for other
drivers like vfio or pci_uio_generic, max_vfs will miss.

But sriov_numvfs is not driver related, just get the vf numbers
from that field.

Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
v2 --> v1:
	backport for kernel version less than 3.8

 lib/librte_eal/linuxapp/eal/eal_pci.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
index b5f5410..fcf5511 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -272,8 +272,16 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,
 	dev->max_vfs = 0;
 	snprintf(filename, sizeof(filename), "%s/max_vfs", dirname);
 	if (!access(filename, F_OK) &&
-	    eal_parse_sysfs_value(filename, &tmp) == 0) {
+	    eal_parse_sysfs_value(filename, &tmp) == 0)
 		dev->max_vfs = (uint16_t)tmp;
+	else {
+		/* for none igb_uio driver, need kernel
+		 * version greater than 3.8 */
+		snprintf(filename, sizeof(filename),
+			 "%s/sriov_numvfs", dirname);
+		if (!access(filename, F_OK) &&
+		    eal_parse_sysfs_value(filename, &tmp) == 0)
+			dev->max_vfs = (uint16_t)tmp;
 	}
 
 	/* get numa node */
-- 
1.9.3

Re: [dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver

[Qiu, Michael]

[+cc] David

On 2/11/2015 9:26 PM, Qiu, Michael wrote:
> max_vfs will only be created by igb_uio driver, for other
> drivers like vfio or pci_uio_generic, max_vfs will miss.
>
> But sriov_numvfs is not driver related, just get the vf numbers
> from that field.
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
> v2 --> v1:
> 	backport for kernel version less than 3.8
>
>  lib/librte_eal/linuxapp/eal/eal_pci.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
> index b5f5410..fcf5511 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
> @@ -272,8 +272,16 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,
>  	dev->max_vfs = 0;
>  	snprintf(filename, sizeof(filename), "%s/max_vfs", dirname);
>  	if (!access(filename, F_OK) &&
> -	    eal_parse_sysfs_value(filename, &tmp) == 0) {
> +	    eal_parse_sysfs_value(filename, &tmp) == 0)
>  		dev->max_vfs = (uint16_t)tmp;
> +	else {
> +		/* for none igb_uio driver, need kernel
> +		 * version greater than 3.8 */
> +		snprintf(filename, sizeof(filename),
> +			 "%s/sriov_numvfs", dirname);
> +		if (!access(filename, F_OK) &&
> +		    eal_parse_sysfs_value(filename, &tmp) == 0)
> +			dev->max_vfs = (uint16_t)tmp;
>  	}
>  
>  	/* get numa node */

Re: [dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver

[David Marchand]

On Wed, Feb 11, 2015 at 2:25 PM, Michael Qiu <michael.qiu@intel.com> wrote:

> max_vfs will only be created by igb_uio driver, for other
> drivers like vfio or pci_uio_generic, max_vfs will miss.
>
> But sriov_numvfs is not driver related, just get the vf numbers
> from that field.
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
> v2 --> v1:
>         backport for kernel version less than 3.8
>
>  lib/librte_eal/linuxapp/eal/eal_pci.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c
> b/lib/librte_eal/linuxapp/eal/eal_pci.c
> index b5f5410..fcf5511 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
> @@ -272,8 +272,16 @@ pci_scan_one(const char *dirname, uint16_t domain,
> uint8_t bus,
>         dev->max_vfs = 0;
>         snprintf(filename, sizeof(filename), "%s/max_vfs", dirname);
>         if (!access(filename, F_OK) &&
> -           eal_parse_sysfs_value(filename, &tmp) == 0) {
> +           eal_parse_sysfs_value(filename, &tmp) == 0)
>                 dev->max_vfs = (uint16_t)tmp;
> +       else {
> +               /* for none igb_uio driver, need kernel
> +                * version greater than 3.8 */
> +               snprintf(filename, sizeof(filename),
> +                        "%s/sriov_numvfs", dirname);
> +               if (!access(filename, F_OK) &&
> +                   eal_parse_sysfs_value(filename, &tmp) == 0)
> +                       dev->max_vfs = (uint16_t)tmp;
>         }
>
>         /* get numa node */
>

I can see a different solution : maybe faking a sriov_numvfs parameter from
igb_uio for kernels that don't have it and doing nothing for kernels that
already provide sriov_numvfs.
But your solution is more straightforward (and we don't need to update
documentation and/or existing scripts afaik).

Acked-by: David Marchand <david.marchand@6wind.com>

-- 
David Marchand

Re: [dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver

[Thomas Monjalon]

2015-02-11 21:25, Michael Qiu:
> max_vfs will only be created by igb_uio driver, for other
> drivers like vfio or pci_uio_generic, max_vfs will miss.
> 
> But sriov_numvfs is not driver related, just get the vf numbers
> from that field.
> 
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
[...]
>  	snprintf(filename, sizeof(filename), "%s/max_vfs", dirname);
>  	if (!access(filename, F_OK) &&
> -	    eal_parse_sysfs_value(filename, &tmp) == 0) {
> +	    eal_parse_sysfs_value(filename, &tmp) == 0)
>  		dev->max_vfs = (uint16_t)tmp;
> +	else {
> +		/* for none igb_uio driver, need kernel

I think it's a typo. Do you mean "for non igb_uio driver"?

> +		 * version greater than 3.8 */
> +		snprintf(filename, sizeof(filename),
> +			 "%s/sriov_numvfs", dirname);
> +		if (!access(filename, F_OK) &&
> +		    eal_parse_sysfs_value(filename, &tmp) == 0)
> +			dev->max_vfs = (uint16_t)tmp;
>  	}
>  
>  	/* get numa node */
> 

Re: [dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver

[Qiu, Michael]

On 2/13/2015 12:26 AM, Thomas Monjalon wrote:
> 2015-02-11 21:25, Michael Qiu:
>> max_vfs will only be created by igb_uio driver, for other
>> drivers like vfio or pci_uio_generic, max_vfs will miss.
>>
>> But sriov_numvfs is not driver related, just get the vf numbers
>> from that field.
>>
>> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> [...]
>>  	snprintf(filename, sizeof(filename), "%s/max_vfs", dirname);
>>  	if (!access(filename, F_OK) &&
>> -	    eal_parse_sysfs_value(filename, &tmp) == 0) {
>> +	    eal_parse_sysfs_value(filename, &tmp) == 0)
>>  		dev->max_vfs = (uint16_t)tmp;
>> +	else {
>> +		/* for none igb_uio driver, need kernel
> I think it's a typo. Do you mean "for non igb_uio driver"?

Hi, Thomas

Yes, you are right.

Did I need to send out V3 patch for this typo?

Thanks,
Michael
>
>> +		 * version greater than 3.8 */
>> +		snprintf(filename, sizeof(filename),
>> +			 "%s/sriov_numvfs", dirname);
>> +		if (!access(filename, F_OK) &&
>> +		    eal_parse_sysfs_value(filename, &tmp) == 0)
>> +			dev->max_vfs = (uint16_t)tmp;
>>  	}
>>  
>>  	/* get numa node */
>>
>

Re: [dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver

[Qiu, Michael]

On 2/12/2015 1:50 PM, David Marchand wrote:
> On Wed, Feb 11, 2015 at 2:25 PM, Michael Qiu <michael.qiu@intel.com
> <mailto:michael.qiu@intel.com>> wrote:
>
>     max_vfs will only be created by igb_uio driver, for other
>     drivers like vfio or pci_uio_generic, max_vfs will miss.
>
>     But sriov_numvfs is not driver related, just get the vf numbers
>     from that field.
>
>     Signed-off-by: Michael Qiu <michael.qiu@intel.com
>     <mailto:michael.qiu@intel.com>>
>     ---
>     v2 --> v1:
>             backport for kernel version less than 3.8
>
>      lib/librte_eal/linuxapp/eal/eal_pci.c | 10 +++++++++-
>      1 file changed, 9 insertions(+), 1 deletion(-)
>
>     diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c
>     b/lib/librte_eal/linuxapp/eal/eal_pci.c
>     index b5f5410..fcf5511 100644
>     --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
>     +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
>     @@ -272,8 +272,16 @@ pci_scan_one(const char *dirname, uint16_t
>     domain, uint8_t bus,
>             dev->max_vfs = 0;
>             snprintf(filename, sizeof(filename), "%s/max_vfs", dirname);
>             if (!access(filename, F_OK) &&
>     -           eal_parse_sysfs_value(filename, &tmp) == 0) {
>     +           eal_parse_sysfs_value(filename, &tmp) == 0)
>                     dev->max_vfs = (uint16_t)tmp;
>     +       else {
>     +               /* for none igb_uio driver, need kernel
>     +                * version greater than 3.8 */
>     +               snprintf(filename, sizeof(filename),
>     +                        "%s/sriov_numvfs", dirname);
>     +               if (!access(filename, F_OK) &&
>     +                   eal_parse_sysfs_value(filename, &tmp) == 0)
>     +                       dev->max_vfs = (uint16_t)tmp;
>             }
>
>             /* get numa node */
>
>
> I can see a different solution : maybe faking a sriov_numvfs parameter
> from igb_uio for kernels that don't have it and doing nothing for
> kernels that already provide sriov_numvfs.

Yes, your solution is much more better, but little complex. My solution
can be a quick fix.

> But your solution is more straightforward (and we don't need to update
> documentation and/or existing scripts afaik).
>
> Acked-by: David Marchand <david.marchand@6wind.com
> <mailto:david.marchand@6wind.com>>
>

Thanks David for reviewing this patch and your good comments

Thanks,
Michale
> -- 
> David Marchand

Re: [dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver

[Thomas Monjalon]

2015-02-13 02:56, Qiu, Michael:
> On 2/13/2015 12:26 AM, Thomas Monjalon wrote:
> > 2015-02-11 21:25, Michael Qiu:
> >> max_vfs will only be created by igb_uio driver, for other
> >> drivers like vfio or pci_uio_generic, max_vfs will miss.
> >>
> >> But sriov_numvfs is not driver related, just get the vf numbers
> >> from that field.
> >>
> >> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> > [...]
> >>  	snprintf(filename, sizeof(filename), "%s/max_vfs", dirname);
> >>  	if (!access(filename, F_OK) &&
> >> -	    eal_parse_sysfs_value(filename, &tmp) == 0) {
> >> +	    eal_parse_sysfs_value(filename, &tmp) == 0)
> >>  		dev->max_vfs = (uint16_t)tmp;
> >> +	else {
> >> +		/* for none igb_uio driver, need kernel
> > I think it's a typo. Do you mean "for non igb_uio driver"?
> 
> Hi, Thomas
> 
> Yes, you are right.
> 
> Did I need to send out V3 patch for this typo?

No, thanks. Your agreement is enough. I'll fix it.

Re: [dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver

[Thomas Monjalon]

> > max_vfs will only be created by igb_uio driver, for other
> > drivers like vfio or pci_uio_generic, max_vfs will miss.
> >
> > But sriov_numvfs is not driver related, just get the vf numbers
> > from that field.
> >
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> 
> I can see a different solution : maybe faking a sriov_numvfs parameter from
> igb_uio for kernels that don't have it and doing nothing for kernels that
> already provide sriov_numvfs.
> But your solution is more straightforward (and we don't need to update
> documentation and/or existing scripts afaik).
> 
> Acked-by: David Marchand <david.marchand@6wind.com>

Applied, thanks